<AWT Dev> <AWT dev>[9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

[Ajit Ghaisas]

The fix looks good.

Regards,
Ajit

-----Original Message-----
From: Sergey Bylokhov 
Sent: Wednesday, October 12, 2016 8:12 PM
To: Manajit Halder
Cc: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> <AWT dev>[9] Review request for JDK-8158380: Regression: java/awt/List/ActionEventTest/ActionEventTest.java

Looks fine.

On 12.10.16 14:40, Manajit Halder wrote:
> Thanks you for your comment. Copyright is corrected in both the tests.
> Please review the modified webrev.
>
> http://cr.openjdk.java.net/~mhalder/8158380/webrev.02/
>
> Thanks,
> Manajit
>
>> On 10-Oct-2016, at 5:58 pm, Sergey Bylokhov 
>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>
>> It seems that "Copyright (c)" is incorrectly updated in both tests.
>>
>> On 10.10.16 14:41, Manajit Halder wrote:
>>> Hi Sergey,
>>>
>>> Thank you for the review. Please review the modified webrev.
>>> http://cr.openjdk.java.net/~mhalder/8158380/webrev.01/
>>>
>>> Thanks,
>>> Manajit
>>>
>>>> On 07-Oct-2016, at 7:41 pm, Sergey Bylokhov 
>>>> <Sergey.Bylokhov at oracle.com <mailto:Sergey.Bylokhov at oracle.com>> wrote:
>>>>
>>>> Hi, Manajit.
>>>> Instead of adding these methods between operations you can call 
>>>> these after robot creation:
>>>>   Robot.setAutoDelay(int ms)
>>>>   Robot.setAutoWaitForIdle(boolean isOn)
>>>>
>>>> On 07.10.16 15:10, Manajit Halder wrote:
>>>>> Hi All,
>>>>>
>>>>> Kindly review the fix for JDK9.
>>>>>
>>>>> Bug:
>>>>> https://bugs.openjdk.java.net/browse/JDK-8158380
>>>>>
>>>>> Webrev:
>>>>> http://cr.openjdk.java.net/~mhalder/8158380/webrev.00/
>>>>>
>>>>> Issue:
>>>>> Regression: java/awt/List/ActionEventTest/ActionEventTest.java
>>>>>
>>>>> Cause:
>>>>> ActionEvent getModifiers() method was returning wrong value in 
>>>>> test ActionEventTest.java due to wrong modifier value.
>>>>> Submenu was not activated by menmonic key press in 
>>>>> SubMenuShowTest.java.
>>>>> In both the cases event queue was not processed completely for 
>>>>> robot keyPress and keyRelease events.
>>>>>
>>>>> Fix:
>>>>> In both the cases problem was solved by adding waitForIdle after 
>>>>> robot operations (keyPress and keyRelease).
>>>>>
>>>>> Regards,
>>>>> Manajit
>>>>
>>>>
>>>> --
>>>> Best regards, Sergey.
>>>
>>
>>
>> --
>> Best regards, Sergey.
>


--
Best regards, Sergey.