<AWT Dev> [9] Review request for 8143914: Provide Mac-specific fullscreen support

Alexander Zvegintsev alexander.zvegintsev at oracle.com
Tue Oct 25 16:25:55 UTC 2016


Please see the updated webrev:

http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/


Thanks,
Alexander.

On 10/11/16 5:00 PM, Alexander Zvegintsev wrote:
> Hi Sergey,
>
> Please see the updated webrev:
>
> http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/
>
> As I can observe other windows  such as native dialogs doesn't have 
> fullscreen button.
>
>
> On 10/2/16 5:52 PM, Sergey Bylokhov wrote:
>> Hi, Alexander.
>> In the fix you use eawt events which are generated by the same peer. 
>> Why not use windowWill/DidEnterFullScreen + 
>> windowWill/DidExitFullScreen?
>> Why the fix is for the Frames only, there are some limitations for 
>> other windows, dialogs etc?
>>
>> On 06.09.16 17:32, Alexander Zvegintsev wrote:
>>> Hello,
>>>
>>> please review the fix
>>>
>>> http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/
>>>
>>> for the issue
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8143914
>>>
>>>
>>> This fix adds the green FullScreen button to a resizable frames by 
>>> default.
>>>
>>> Previous maximize behavior is still accessible by holding Alt while
>>> clicking on the green button.
>>>
>>> setResizable is fixed because of two reasons:
>>>
>>> Window will not be able to leave fullscreen if we remove resizable from
>>> style bits(and even if we set it again)
>>>
>>> Window will not have the green button(maximize/zoom or fullscreen) if
>>> the window was initially not resizable.
>>>
>>>
>>
>>
>



More information about the awt-dev mailing list