<AWT Dev> AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords

[Lindenmaier, Goetz]

Hi Matthias,

thanks for looking at this change.

I fixed the copyrights, (I actually had a bug skipping 2015, --> 2015, 2017, in my script).
I also adapted the "summary" and double checked jtreg is parsing this correctly.
(I was not sure with the line break and # comments.)

The test test/java/awt/print/PrinterJob/Margins.java
Just opens a window "No printer found" and terminates as 'passed'
if the printer is missing. So I would prefer to skip the
'printer' key from that test.

New webrev:

http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.02/



Best regards,

  Goetz.




From: Baesken, Matthias
Sent: Freitag, 11. August 2017 09:29
To: awt-dev at openjdk.java.net; Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
Subject: re : AWT Dev> [ping] RFR(M): 8185500: [TESTBUG] Add keywords



Ø  I added more headful tests that are only run on windows.  I also added

Ø  some @requires os=windows where obvious.

Ø  I would appreciate a review!

Ø  http://cr.openjdk.java.net/~goetz/wr17/8185500-headlessKey/webrev.01/


Hi Götz, not a reviewer  but I noticed  a few  of the files need  Copyright  year update  , for example

test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java

test/java/awt/im/6396526/IMLookAndFeel.java

test/java/awt/print/PrinterJob/ExceptionTest.java

test/java/awt/print/PrinterJob/ImagePrinting/NullClipARGB.java

test/java/awt/print/PrinterJob/PrintTextPane.java

test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java

test/javax/swing/JInternalFrame/8075314/bug8075314.java

test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java

test/javax/swing/JMenuItem/ClickMenuTestManual/ClickMenuTestManual.java

test/javax/swing/text/html/Test4783068.java



Does that one need   tag  printer as well ?

test/java/awt/print/PrinterJob/Margins.java


This  test  got a  very  long line in the  "summary"  of the tagging section, maybe better use 2 lines :

test/javax/print/PrintSE/PrintSE.sh


Otherwise looks ok to me .

Best regards, Matthias
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20170811/ab755baf/attachment-0001.html>