<AWT Dev> [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
ambarish.rapte at oracle.com
Wed Jan 11 08:10:41 UTC 2017
Fix looks good.
But I think the file GenerateTestImage.java should be omitted from patch as it does not have any fix related change.
From: Rahul Singh
Sent: Friday, January 06, 2017 11:22 AM
To: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
The "user.dir" is saving the generated image in a common folder scratch whereas "test.classes" is saving it to a specific folder. Compiling the test file before running it is actually solving the problem.
On 1/4/2017 5:32 PM, Rahul Singh wrote:
On 1/4/2017 10:38 AM, Ajit Ghaisas wrote:
The fix looks good.
I suggest to replace wildcard import statements with specific ones in both the files in webrev.
From: Rahul Singh
Sent: Tuesday, January 03, 2017 6:17 PM
To: HYPERLINK "mailto:awt-dev at openjdk.java.net"awt-dev at openjdk.java.net
Subject: <AWT Dev> [awt-dev] Request for Approval and Review: JDK-8140329 [TEST BUG] java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java
Please review the fix for the bug: HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-7146533"JDK-8140329 [TEST BUG]
The test java/awt/SplashScreen/FullscreenAfterSplash/FullScreenAfterSplash.java fails to create test.png in the given path by GenerateTestImage.java utility. I used "user.dir" to obtain the path.
Bug Link: HYPERLINK "https://bugs.openjdk.java.net/browse/JDK-7146533"https://bugs.openjdk.java.net/browse/JDK-8140329
The webrev is : HYPERLINK "http://cr.openjdk.java.net/%7Evagarwal/8140329/webrev/"http://cr.openjdk.java.net/~vagarwal/8140329/webrev/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the awt-dev