<AWT Dev> [10] Review Request: 8187639 TrayIcon is not properly supported on macOS in multi-screen environment

Phil Race philip.race at oracle.com
Mon Oct 16 19:30:26 UTC 2017

- Why do we scale the icon by 0.75 ? I could be missing something but
    it appears that this will be based off the same image whether it is 
retina or not
    and I wonder if we really should be scaling it down on retina ?

- Are we losing anything by no longer knowing when the user has 
dismissed the notification ?

- I suppose a test case for this is hard ?

- Can perhaps attach an "after the fix" screen shot to the bug report ?


On 09/27/2017 10:07 AM, Sergey Bylokhov wrote:
> Hello,
> Please review the fix for jdk10.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8187639
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8187639/webrev.01
> Since macOS 10.9(or even early) the main menubar is shown on all 
> screens(not only on the main screen), which means that on both screens 
> the trayIcons are visible.
> Our code is not ready for this situation, because we create a custom 
> notification window and tries to place it near the trayicon on the 
> main screen.
> Instead of updating the logic of showing the window, I migrated the 
> code to the standard notification mechanism which is used in macOS.
> Examples:
> The old message: http://cr.openjdk.java.net/~serb/8187639/images/Old.png
> The new(java -jar): 
> http://cr.openjdk.java.net/~serb/8187639/images/Command%20line.png
> The new(bundles application): 
> http://cr.openjdk.java.net/~serb/8187639/images/Bundled%20applicateion.png

More information about the awt-dev mailing list