<AWT Dev>  Review request for 8074824: Resolve disabled warnings for libawt_xawt
philip.race at oracle.com
Mon Oct 16 21:11:37 UTC 2017
I don't follow why you chose sun/java2d/* tests to run but so long as they
cover the right code that should be OK.
On 10/16/2017 01:14 PM, Semyon Sadetsky wrote:
> Hi Phil,
> On 10/13/2017 12:42 PM, Phil Race wrote:
>> The changes look fine but I am obliged to ask some questions before
>> approving ..
>> My #1 question here, is how did you test this ?
>> Specifically I'd like to hear that this passes on all affected
>> platforms using the "blessed" compilers,
>> which in practice is most easily verified by submitting a job to our
>> (ahem) internal build systems.
>> And do you know if this will force usage of --disable-warnings on any
>> conmonly used compilers ?
> I ran it on JPRT and on my local env. You can try it on your favorite
> gcc version. I have no idea weather it will be successful on other
>> Also due to the change of approach in defining shader programs you
>> really should
>> run some tests with the OGL pipeline too ..
> I ran OGL tests and found a typo. Below the update webrev:
> Before and after this path the sun/java2d/* tests ran with
> -Dsun.java2d.opengl=True are in the same shape: 5 failures and 1 error.
>> On 10/13/2017 11:20 AM, Semyon Sadetsky wrote:
>>> Please review fix for JDK10:
>>> webrev: http://cr.openjdk.java.net/~ssadetsky/8074824/webrev.00/
>>> The eliminates gcc warnings produced during compilation of xawt
More information about the awt-dev