<AWT Dev> [10] Review Request: JDK-8145795 : [PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Oct 16 22:33:06 UTC 2017


Hi, Pankaj.
Can you please check that the same changes needs to be applied to the 
XToolkit:

X11GraphicsConfig.scaleUp()
X11GraphicsConfig.scaleDown()
XlibUtil.scaleDown()

On 09/10/2017 00:53, Pankaj Bansal wrote:
> Hi,
> 
> Please review the fix for JDK 10.
> 
> Bug:
> 
> https://bugs.openjdk.java.net/browse/JDK-8145795
> 
> Webrev:
> 
> http://cr.openjdk.java.net/~aghaisas/pankaj/8145795/webrev.00/
> 
> Issue:
> 
> The awt window size is capped at a max value, but with hidpi support, an 
> regression was introduced because of which the window size is wrong and 
> even INT_MAX window size is possible.
> 
> Fix:
> 
> The issue is due to the int overflow. There was no check to keep the 
> window size between int min and max values. Due to which, the windows 
> size was wrong. Added int limit checks.
> 
> Regards,
> 
> Pankaj Bansal
> 


-- 
Best regards, Sergey.


More information about the awt-dev mailing list