<AWT Dev> [10] Review request for 8074824: Resolve disabled warnings for libawt_xawt

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Oct 16 23:45:16 UTC 2017

Hi, Semyon.
A few notes:> I ran OGL tests and found a typo. Below the update webrev> 

  - What is a typo? It seems the v0 and v1 are identical.
  - The new "IS_SAFE_SIZE_T" macro returns different result than the old 
one for "0"
  - What is the reason to inline some of the shaders in OGLPaints.c and 
leave as-is others? For example "noCycleCode" was inlined and 
"texCoordCalcCode" still stored in the "static const char *". It seems 
that the "static const" style is more readable.

Best regards, Sergey.

More information about the awt-dev mailing list