<AWT Dev>  Review Request: JDK-8145795 : [PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)
pankaj.b.bansal at oracle.com
Thu Oct 19 06:04:29 UTC 2017
Yes, I missed that. I have updated the webrev. Please review.
From: Sergey Bylokhov
Sent: Wednesday, October 18, 2017 2:52 AM
To: Pankaj Bansal; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev>  Review Request: JDK-8145795 : [PIT] java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can assign Integer.MAX_VALUE to Window dimensions)
On 17/10/2017 04:48, Pankaj Bansal wrote:
> I can see that XDragSourceContextPeer.java also contains ScaleUp and ScaleDown functions, but I don't see them being called from anywhere. So have not made changes in the same.
Looks like XDragSourceContextPeer.scaleUp() is unused, but scaleDown() is used in a few places.
> Pankaj Bansal
> -----Original Message-----
> From: Sergey Bylokhov
> Sent: Tuesday, October 17, 2017 4:03 AM
> To: Pankaj Bansal; awt-dev at openjdk.java.net
> Subject: Re: <AWT Dev>  Review Request: JDK-8145795 : [PIT]
> java/awt/Window/ScreenLocation/ScreenLocationTest.java fails (can
> assign Integer.MAX_VALUE to Window dimensions)
> Hi, Pankaj.
> Can you please check that the same changes needs to be applied to the
> On 09/10/2017 00:53, Pankaj Bansal wrote:
>> Please review the fix for JDK 10.
>> The awt window size is capped at a max value, but with hidpi support,
>> an regression was introduced because of which the window size is
>> wrong and even INT_MAX window size is possible.
>> The issue is due to the int overflow. There was no check to keep the
>> window size between int min and max values. Due to which, the windows
>> size was wrong. Added int limit checks.
>> Pankaj Bansal
> Best regards, Sergey.
Best regards, Sergey.
More information about the awt-dev