<AWT Dev> [10] Review Request: JDK-8159062 : [hidpi] DnD on Windows while scaling is non-integer
Sergey Bylokhov
Sergey.Bylokhov at oracle.com
Tue Oct 24 19:33:48 UTC 2017
Hi, Pankaj.
Please provide a test case for the issue.
On 24/10/2017 02:43, Pankaj Bansal wrote:
> Hi All,
>
> Please review the fix for JDK 10.
>
> Bug:
>
> https://bugs.openjdk.java.net/browse/JDK-8159062
>
> Webrev:
>
> http://cr.openjdk.java.net/~psadhukhan/pankaj/JDK-8159062-webrev.00/
>
> Issue:
>
> There are issue with the mouse move events when HIDPI scale is set to
> some non-integer value like 1.25, 1.5, 2.5.
>
> Fix:
>
> The issue is due to precision error. In native side in the
> awt_Win32GraphicsDevice class, ScaleUp and ScaleDown functions are used
> to get scaled value where ceil is used. But in java side, ClipRound is
> used which rounds the value instead of ceil. I think we should be doing
> round in native side also. This fixes the issue.
>
> Regards,
>
> Pankaj Bansal
>
--
Best regards, Sergey.
More information about the awt-dev
mailing list