<AWT Dev> RFR: [12] JDK-8196681: Java Access Bridge logging and debug flags dynamically controlled

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Dec 10 21:06:43 UTC 2018

Hi, Krishna.

On 10/12/2018 06:38, Krishna Addepalli wrote:
> The only way to avoid changes to make file is by using C string manipulation API.
> Here is the webrev: http://cr.openjdk.java.net/~kaddepalli/8196681/webrev08 , although I would personally prefer using the C++ api.

Throwing a c++ exception out of "extern C", when the method is called from the other language is UB,
so we should not throw any exception and use c++, or use plain c.

Comment about the current version:
  - Do we handle the absent of the slash at the end of the path in "JAVA_ACCESSBRIDGE_LOGFILE"?
  - in some place you use auto and in another same situation you use "size_t", please unify.

Best regards, Sergey.

More information about the awt-dev mailing list