<AWT Dev> [11] JDK-8129569: [TEST_BUG] Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

[Shashidhara Veerabhadraiah]

Hi, Please find the updated webrev per the comments:
http://cr.openjdk.java.net/~sveerabhadra/8129569/webrev.01/

Thanks and regards,
Shashi

-----Original Message-----
From: Shashidhara Veerabhadraiah 
Sent: Wednesday, February 21, 2018 9:22 AM
To: Philip Race <philip.race at oracle.com>; Sergey Bylokhov <sergey.bylokhov at oracle.com>; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> [11] JDK-8129569: [TEST_BUG] Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

Thank you Phil and Sergey for the clarification.

Thanks and regards,
Shashi

-----Original Message-----
From: Phil Race
Sent: Wednesday, February 21, 2018 2:26 AM
To: Sergey Bylokhov <sergey.bylokhov at oracle.com>; Shashidhara Veerabhadraiah <shashidhara.veerabhadraiah at oracle.com>; awt-dev at openjdk.java.net
Subject: Re: <AWT Dev> [11] JDK-8129569: [TEST_BUG] Test java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java fails

If jtreg ran all tests ran in othervm mode it would likely take much longer .. which is a big reason why the default is agentvm and not othervm.
If the test destabilises the VM or is a resource hog, or needs VM special settings (eg setting a system property) then othervm would be the way to go.

-phil.


On 02/20/2018 11:23 AM, Sergey Bylokhov wrote:
> On 20/02/2018 09:58, Shashidhara Veerabhadraiah wrote:
>> But in general, isn't the othervm is preferable?
>
> If it is not critical for the test it is better to use a default mode, 
> which maybe an agentvm(this mode can be faster than othervm).
>
>>
>> Thanks and regards,
>> Shashi
>>
>> -----Original Message-----
>> From: Sergey Bylokhov
>> Sent: Tuesday, February 20, 2018 8:06 PM
>> To: Shashidhara Veerabhadraiah
>> <shashidhara.veerabhadraiah at oracle.com>; awt-dev at openjdk.java.net
>> Subject: Re: [11] JDK-8129569: [TEST_BUG] Test 
>> java/awt/Frame/MaximizedToUnmaximized/MaximizedToUnmaximized.java
>> fails
>>
>> Hi, Shashi.
>> Why have you changed the test to othervm?
>>
>> On 20/02/2018 02:09, Shashidhara Veerabhadraiah wrote:
>>> Hi All, Please review a test bug fix for the below bug.
>>>
>>>                  Bug: 
>>> https://bugs.openjdk.java.net/browse/JDK-8129569
>>>
>>>                  Webrev:
>>> http://cr.openjdk.java.net/~sveerabhadra/8129569/webrev.00/
>>>
>>> Summary: This test was added as part of code fix for the bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8065739 under the changeset:
>>> http://hg.openjdk.java.net/jdk9/client/jdk/rev/1457bd69ac5a. If one 
>>> examines the code updates done under this changeset it all relates 
>>> to the mac platform. Hence this test is updated to run on mac 
>>> platform only.
>>>
>>> Thanks and regards,
>>> Shashi
>>>
>>
>>
>> --
>> Best regards, Sergey.
>>
>
>