<AWT Dev> [11] Review Request: 8198335 java/awt/FullScreen/UninitializedDisplayModeChangeTest/UninitializedDisplayModeChangeTest.java fails in headless mode

[Philip Race]

I presume the headful keyword means thie can't be run in our nightly 
tests ..and
isn't supposed to be run in headless mode, so I am a bit puzzled by the 
change.
I also don't understand why it would be "random".

   * @key headful
   * @summary Tests that no exception is thrown when display mode is changed
   *          externally
   * @compile UninitializedDisplayModeChangeTest.java DisplayModeChanger.java
   * @run main/othervm UninitializedDisplayModeChangeTest
+ * @run main/othervm -Djava.awt.headless=true UninitializedDisplayModeChangeTest
   */

-phil.

On 3/20/18, 11:48 AM, Sergey Bylokhov wrote:
> Hello.
> Please review fix for jdk11.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8198335
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8198335/webrev.01
>
> This bug cause the random failures of our headless tests. The reason 
> is that we try to notify the 
> GraphicsEnvironment(HeadlessGraphicsEnvironment), which does not 
> implement DisplayChangedListener, about display change.
>
> It is possible to skip this notification for headlesGE only, but I 
> think that it is better to make instanceof before cast to 
> DisplayChangedListener, usually we use this pattern in other places.
>
> PS. Note that WToolkit.paletteChanged and WToolkit.displayChanged use 
> different threads for notifications, I have created a bug to 
> investigate this: https://bugs.openjdk.java.net/browse/JDK-8199881
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/awt-dev/attachments/20180326/e9efb7a3/attachment.html>