<AWT Dev> RFR: 8227587: Add internal privileged System.loadLibrary

Philip Race philip.race at oracle.com
Fri Jul 12 14:14:55 UTC 2019


Regarding all the touches on the desktop module
1) awt-dev isn't the only list, you should have included swing-dev and 
2d-dev at least
2) I am wondering what client testing you propose to do to verify this ?

3) I've spent spare time over a number of months trying to decrease
unnecessary coupling between desktop and base modules. This seems to create
additional technical debt there with minimal benefit, so in other words
I'd much prefer that either you don't do this at all or the many, many,
uses in the desktop module that are the heaviest Java->native code
user in the JDK are dealt with entirely separately (separate bug) and at 
a minimum
there is one place in the desktop module that they all call to and
perhaps only then *through*.

So do not push this.


On 7/12/19, 6:27 AM, Roger Riggs wrote:
> Hi Claes,
> Looks fine.
> Thanks for the updates, Roger
> On 7/11/19 10:39 AM, Claes Redestad wrote:
>> Hi Roger,
>> On 2019-07-11 16:10, Roger Riggs wrote:
>>> Hi Claes,
>>> JavaLangAccess.java:
>>> 316: Add @param tag
>> done.
>>> System.java:  2282, 2287
>>> Runtime.loadLibrary0 makes a second check for a security manager.
>>> Is there any potential gain by calling ClassLoader.loadLibrary 
>>> directly?
>>> None of the internal uses would have a separatorChar.
>> Most of the gain comes from not having to load one-off PA classes or
>> lambdas, but of course avoiding the indexOf and a few indirections are
>> marginally helpful to startup. We should at least assert that the
>> library names are sane, though.
>>> I expect most of the files need a copyright update.
>>> The script in <repo>/make/scripts/update_copyright_year.sh should do 
>>> the work for modified files.
>> Fixed copyrights and updated in place: 
>> http://cr.openjdk.java.net/~redestad/8227587/open.00
>> Thanks!
>> /Claes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190712/b49ffa4c/attachment.html>

More information about the awt-dev mailing list