<AWT Dev>  Review Request: 8219504 Test for JDK-8211435 can be run on all platforms
shashidhara.veerabhadraiah at oracle.com
Thu Mar 7 15:45:49 UTC 2019
Hi Sergey, I think you need to add "@run main" command and this bug id to the "@bug" list of bugs. Also you can update the copyright year to this year as well.
Thanks and regards,
From: Dmitry Markov
Sent: Thursday, March 7, 2019 2:59 PM
To: Sergey Bylokhov <sergey.bylokhov at oracle.com>
Cc: awt-dev at openjdk.java.net
Subject: Re: <AWT Dev>  Review Request: 8219504 Test for JDK-8211435 can be run on all platforms
The fix looks good to me.
> On 7 Mar 2019, at 06:59, Sergey Bylokhov <sergey.bylokhov at oracle.com> wrote:
> Thank you for review!
> Looking for the second +1 from someone else.
> On 20/02/2019 22:20, Krishna Addepalli wrote:
>> -----Original Message-----
>> From: Sergey Bylokhov
>> Sent: Thursday, February 21, 2019 8:01 AM
>> To: awt-dev at openjdk.java.net
>> Subject: <AWT Dev>  Review Request: 8219504 Test for JDK-8211435
>> can be run on all platforms Hello.
>> Please review the fix for jdk 13.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8219504
>> Fix: http://cr.openjdk.java.net/~serb/8219504/webrev.00
>> Currently the test for JDK-8211435 is executed on macOS only, because of JDK-8204142:
>> But since JDK-8204142 was fixed we can run it on all platforms.
>>  https://bugs.openjdk.java.net/browse/JDK-8204142
> Best regards, Sergey.
More information about the awt-dev