<AWT Dev> [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

[Thomas Stüfe]

Sorry, not awt/2d group, but to me it looks fine too. Only nit: the error
printout at 495 I would put right after the associated dlsym at 456. You
want to make sure dlerror() is not stale at the point where you call it,
since it would return NULL.

Cheers, Thomas



On Mon, Mar 18, 2019 at 3:17 PM Volker Simonis <volker.simonis at gmail.com>
wrote:

> Ping...
>
> Can I please also get a review from the awt/2d group?
>
> Thanks,
> Volker
>
> On Wed, Mar 13, 2019 at 11:09 AM Volker Simonis
> <volker.simonis at gmail.com> wrote:
> >
> > Hi,
> >
> > can I please have a review for the following change which fixes
> > Xinerama and Xrender support on AIX:
> >
> > http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/
> > https://bugs.openjdk.java.net/browse/JDK-8220528
> >
> > The change basically fixes the way how the corresponding libraries
> > (libXext and libXrender) get loaded on AIX and does some cleanups with
> > regards to the various platform macros. I've also added some debug
> > tracing to the Xrender initialization code similar to the Xinerama
> > initialization.
> >
> > Thank you and best regards,
> > Volker
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/awt-dev/attachments/20190318/589372ff/attachment.html>