<AWT Dev> RFR: 8240290 Clean the "libawt_xawt" library from code for macOS and headless mode

Sergey Bylokhov Sergey.Bylokhov at oracle.com
Mon Apr 13 13:13:21 UTC 2020

Hi, Phil.

> PS meaning do (1) first, and revisit (2) later.

The fix is updated:

> And I am not sure (2) is - or was always an error.
> The code can use these fns as stubs to prevent runtime link errors
> I thought that the purpose ..

I extracted it to the separate bug

> -phil.
> On 4/7/20, 3:20 PM, Philip Race wrote:
>> This fix is conflating two things
>> 1) removing the macos references
>> 2) making the build fail if they are used in a headless build
>> I'd prefer to see these unrelated fixes separated
>> -phil.
>> On 3/2/20, 3:36 AM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk/client.
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8240290
>>> Fix: http://cr.openjdk.java.net/~serb/8240290/webrev.00
>>> The libawt_xawt.so library is used by the headful toolkit only and only on Unix,
>>> but it still uses some code related to macOS(the time when macport project used XToolkit)
>>> and headless mode, which should be deleted.
>>> In the fix, all usage of #HEADLESS and #MACOSX in libawt_xawt were removed.
>>> In each file the assert "#error This file " is added to prove that these
>>> files are unused in headless mode.
>>> mach5 is green

Best regards, Sergey.

More information about the awt-dev mailing list