<AWT Dev> RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

Igor Ignatyev igor.ignatyev at oracle.com
Thu Apr 16 17:02:25 UTC 2020

Thanks for your review, Sergey.

-- Igor

> On Apr 16, 2020, at 1:43 AM, Sergey Bylokhov <Sergey.Bylokhov at oracle.com> wrote:
> Looks fine.
> On 4/15/20 10:22 pm, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
>>> 35 lines changed: 26 ins; 0 del; 10 mod
>> Hi all,
>> 8233827[1] which added screenshots to so-called failure handler had an unexpected side-effect on linux, where users might observer flashes each time a screenshot is taken, which, to put it mildly, is annoying. the patch replaces gnome-screenshot app w/ calling java.awt API to make a screenshot. the patch also uses the same solution to make screenshots on windows and solaris (which previously didn't save screenshots on failures). we still use native app on mac as using java.awt API requires accessibility permissions, which might be as annoying as flashes on linux.
>> [1] https://bugs.openjdk.java.net/browse/JDK-8233827
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8240904
>> webrev: http://cr.openjdk.java.net/~iignatyev//8240904/webrev.00
>> testing: verified that screenshots are successfully generated on headful systems, and headless systems ignore errors ('java.awt.AWTException: headless environment' from j.a.Robot::<init>).
>> Thanks,
>> -- Igor
> -- 
> Best regards, Sergey.

More information about the awt-dev mailing list