<AWT Dev> RFR: 8264428: Cleanup usages of StringBuffer in java.desktop [v4]
azvegint at openjdk.java.net
Thu Apr 8 15:26:18 UTC 2021
On Thu, 8 Apr 2021 14:43:50 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:
>> There are few possible cleanups in java.desktop related to legacy StringBuffer usages:
>> 1. In few places StringBuffer can be replaced with plain String concatenation.
>> 2. StringBuffer can be replaced with StringBuilder. StringBuilder has better performance as it is not thread-safe.
>> 3. There are few places where result of string concatenation is passed to StringBuffer.append method. Using separate `.append` calls is more clear.
>> 4. In few places primitives are unnecessary converted to String before `.append` call. They can be replaced with specialized methods (like `.append(int)` calls.
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 8264484: Replace uses of StringBuffer with StringBuilder in jdk.hotspot.agent
> place each 'append' call on its own line
Marked as reviewed by azvegint (Reviewer).
More information about the awt-dev