<AWT Dev> RFR: 8260616: Removing remaining JNF dependencies in the java.desktop module [v3]

Phil Race prr at openjdk.java.net
Mon Feb 1 19:09:59 UTC 2021

> This completes the desktop module JNF removal
> * remove  -framework JavaNativeFoundation from make files
> * remove  #import <JavaNativeFoundation/JavaNativeFoundation.h> from all source files. If needed add import of JNIUtilities.h to get jni.h definitions - better anyway since then it gets the current JDK ones not the ones from the O/S
> * replace JNFNSToJavaString with NSStringToJavaString and  JNFJavaToNSString with JavaStringToNSString
> * replace JNFNormalizedNSStringForPath with NormalizedPathNSStringFromJavaString and JNFNormalizedJavaStringForPath with NormalizedPathJavaStringFromNSString
> * replace JNFGet/ReleaseStringUTF16UniChars with direct calls to JNI
> * Map all JNFRunLoop perform* calls to the ThreadUtilities versions (the vast majority already did this)
> * Redo the ThreadUtilities calls to JNFRunLoop to directly invoke NSObject perform* methods.
> * define new javaRunLoopMode in ThreadUtilities to replace the JNF one and use where needed.
> * Remove the single usage of JNFPerformEnvBlock
> * replace JNFJavaToNSNumber in single A11Y file with local replacement
> * replace single usage of JNFNSTimeIntervalToJavaMillis in ScreenMenu.m with local replacement
> * remove un-needed JNFRunLoopDidStartNotification from NSApplicationAWT.m
> * misc. remaining cleanup (eg missed JNF_CHECK_AND_RETHROW_EXCEPTION)

Phil Race has updated the pull request incrementally with one additional commit since the last revision:

  8260616: Removing remaining JNF dependencies in the java.desktop module


  - all: https://git.openjdk.java.net/jdk/pull/2305/files
  - new: https://git.openjdk.java.net/jdk/pull/2305/files/efab1de5..7ea57c85

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2305&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2305&range=01-02

  Stats: 46 lines in 3 files changed: 34 ins; 1 del; 11 mod
  Patch: https://git.openjdk.java.net/jdk/pull/2305.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/2305/head:pull/2305

PR: https://git.openjdk.java.net/jdk/pull/2305

More information about the awt-dev mailing list