<AWT Dev> RFR: 8256465: [macos11] Java frame and dialog presented full screen freeze application [v9]

Tejpal Rebari trebari at openjdk.java.net
Thu Jun 3 12:51:27 UTC 2021

> Hi All,
> Please review the following fix for jdk17.
> Issue : On MacOS 11 Java Frame and JDialog application is freezing  in Full Screen  when the System Preference -> General -> Prefer Tabs is set to "Full Screen". It is also freezing in normal screen when Prefer Tabs is set to "Always".
> It doesn't freeze when the Prefer tabs is set to "never".
> Fix : The default value of allowsAutomaticWindowTabbing is 0/NO in MacOS prior to bigSur(11)  
> (in the AWTWindow.m file),  so the issue is not seen in mac os 10.13 10.14 and 10.15.
> From MacOS 11 onwards  this value is set to 1/YES and the issue is seen.
> This issue can also be reproduced in MacOS 10.15 by setting setAllowsAutomaticWindowTabbing to true in the AWTWindow.m file.
> Fix is to set allowsAutomaticWindowTabbing to No for all the MacOS release staring from 10.12.
> The allowsAutomaticTabbing was introduced in MacOS 10.12 but the default value changed in macos11.
> Test : Added a manual test and tested on MacOS 10.15 and 11.
> All the internal tests run are green.

Tejpal Rebari has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into 8256465
 - updated the comment
 - make string final
 - doPrivileged to the system.getproperty
 - addressed review comments
 - made changed according to CSR comments
 - initialize in static block added doprivilged and removed @available
 - code cleanup
 - Merge remote-tracking branch 'upstream/master' into 8256465
 - add system property
 - ... and 1 more: https://git.openjdk.java.net/jdk/compare/6fe46985...28752a2c


  - all: https://git.openjdk.java.net/jdk/pull/3407/files
  - new: https://git.openjdk.java.net/jdk/pull/3407/files/7fbb729e..28752a2c

 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3407&range=08
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3407&range=07-08

  Stats: 129126 lines in 4462 files changed: 46743 ins; 68014 del; 14369 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3407.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3407/head:pull/3407

PR: https://git.openjdk.java.net/jdk/pull/3407

More information about the awt-dev mailing list