<AWT Dev> RFR: 8182043: Access to Windows Large Icons [v6]

Alexey Ivanov aivanov at openjdk.java.net
Fri May 14 13:40:38 UTC 2021

On Tue, 11 May 2021 21:41:15 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Fix updated after first round of review.
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>   Make getShell32Icon method return multi-resolition image in case of
>   requested icon size and actual icon size mismatch.

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 266:

> 264:     * {@code ShellFolder} class. Whenever possible, the icon
> 265:     * returned will be a multi-resolution icon image,
> 266:     * which will allow better support for High DPI environments

I'm not sure but probably “…which allows better…” is more grammatical, as well as in the line above: “the icon returned is a multi-resolution”.

Phil or Joe could correct this.


PR: https://git.openjdk.java.net/jdk/pull/2875

More information about the awt-dev mailing list