<AWT Dev> RFR: 8182043: Access to Windows Large Icons [v10]

Sergey Bylokhov serb at openjdk.java.net
Thu May 20 16:09:44 UTC 2021

On Thu, 20 May 2021 07:30:00 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Fix updated after first round of review.
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>   Empty <p> tag before @implSpec causes warning during javadoc generation

test/jdk/javax/swing/JFileChooser/FileSystemView/SystemIconTest.java line 72:

> 70:             if (icon.getImage() instanceof MultiResolutionImage) {
> 71:                 MultiResolutionImage mri = (MultiResolutionImage) icon.getImage();
> 72:                 if (mri.getResolutionVariant(size, size) == null) {

This is to describe one of my questions above, is this instanceof+cast cannot be improved? Why we cannot always wrap the data in the MRI and if we have only one icon return the MRI with one resolution?


PR: https://git.openjdk.java.net/jdk/pull/2875

More information about the awt-dev mailing list