<AWT Dev> RFR: 8182043: Access to Windows Large Icons [v14]

Phil Race prr at openjdk.java.net
Wed May 26 14:57:20 UTC 2021

On Tue, 25 May 2021 23:36:43 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Fix updated after first round of review.
> Alexander Zuev has updated the pull request incrementally with one additional commit since the last revision:
>   null file now properly causes IllegalArgumentException
>   Small fixed in JavaDoc

Approving but fix  the grammar!

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 282:

> 280:     * @return an icon as it would be displayed by a native file chooser
> 281:     * or null if invalid parameters are passed such as reference to a
> 282:     * non-existent file.

grammar : "a reference"

src/java.desktop/share/classes/javax/swing/filechooser/FileSystemView.java line 285:

> 283:     * @throws IllegalArgumentException if invalid parameter such
> 284:     * as negative size or null file reference is passed.
> 285:     * @see JFileChooser#getIcon

minor grammar : add "an"or "a" as appropriate, ie change to : 
"if an invalid parameter such a negative size or a null file reference"


Marked as reviewed by prr (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/2875

More information about the awt-dev mailing list