<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi, Semyon.<br>
That's a specification which should be read as written. But if you
mean this is not the same things, then it is unclear what value
will be added to the description of "awt.mouse.numButtons"
property, which mentions in the specification for the first time.
Since getNumberOfButtons obtain something not specified from the
getToolkit, modify it somehow(w/o specification) and returns. See
for example Toolkit.getToolkit and Toolkit.
<meta http-equiv="content-type" content="text/html; charset=utf-8">
areExtraMouseButtonsEnabled(). It is not necessary write so
specific specification but at least it should be clear.<br>
<br>
It would be good to rephrase it somehow.<br>
<br>
12.03.15 0:09, Semyon Sadetsky wrote:<br>
</div>
<blockquote cite="mid:55013BB2.5060104@oracle.com" type="cite">Hi
Sergey,
<br>
<br>
I didn't find any mention in the new text that the method returns
the same value as Tolkit.get... returns.
<br>
I'm not an expert in English but in my opinion "obtained by" verb
doesn't state that the same value is returned without any
handling.
<br>
Maybe you've mixed it up with "proxy"?
<br>
<br>
Thanks,
<br>
--Semyon
<br>
<br>
<br>
On 3/12/2015 9:47 AM, Sergey Bylokhov wrote:
<br>
<blockquote type="cite">Hi, Semyon.
<br>
The fix in general is correct, but it adds an assertion that
this method should return the same values as Toolkit.get...
<br>
And this is incorrect, and we can get a new CR that
implementation don't follow the specification. Probably we can
simplify it and state that we use numeric value from desktop
property or something like that?
<br>
<br>
11.03.15 22:52, Semyon Sadetsky wrote:
<br>
<blockquote type="cite">Hello,
<br>
<br>
please review fix for jdk9.
<br>
<br>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/7081580/webrev.00/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/7081580/webrev.00/</a>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-7081580">https://bugs.openjdk.java.net/browse/JDK-7081580</a>
<br>
<br>
Thanks,
<br>
--Semyon
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</body>
</html>