<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">The fix looks good to me.<br>
      <br>
      11.03.15 13:13, Semyon Sadetsky wrote:<br>
    </div>
    <blockquote cite="mid:55001539.9020405@oracle.com" type="cite">
      <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
      Hi Sergey,<br>
      <br>
      Thank you for your response.<br>
      I have added max+-1 cases to the test. <br>
      <br>
      <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/semyon-sadetsky/8072769/webrev.05/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.05/</a>
      <br>
      <br>
      cases 0,1, etc are not related to the bug. I understand you
      worries about test coverage but I think it's better to follow the
      process.<br>
      You can file a ticket to increase system tray test coverage and we
      immediately start to work on it upon it is prioritized. <br>
      <br>
      --Semyon<br>
      <br>
      <br>
      <div class="moz-cite-prefix">On 3/4/2015 11:17 PM, Sergey Bylokhov
        wrote:<br>
      </div>
      <blockquote cite="mid:54F7684E.6080700@oracle.com" type="cite">
        <meta content="text/html; charset=utf-8"
          http-equiv="Content-Type">
        <div class="moz-cite-prefix">On 04.03.2015 16:33, Semyon
          Sadetsky wrote:<br>
        </div>
        <blockquote cite="mid:54F709B9.2030700@oracle.com" type="cite">
          <meta content="text/html; charset=utf-8"
            http-equiv="Content-Type">
          Sergey, <br>
          OK. You can file a request to improve TrayIcon test coverage
          but it's an another story. Here we are discussing regression
          test for a specific bug.<br>
          I cannot agree with the approach you've proposed. In your
          logic we need start to write regression tests for all methods
          in JDK classes those take String parameters by iterating all
          possible parameters lengths to discover potential bugs.<br>
        </blockquote>
        Yes, if we know that there is a high probability to crash the
        method.
        <blockquote cite="mid:54F709B9.2030700@oracle.com" type="cite">
          Tests need to be written by certain rules. Scanning all
          possible values of input parameters is not the best rule in my
          opinion.<br>
        </blockquote>
        Validation of one number is useless too. Its even does not check
        all corner cases , 0,1,max-1,max,max+1. so the range is better.<br>
        <blockquote cite="mid:54F709B9.2030700@oracle.com" type="cite">
          <br>
          --Semyon<br>
          <br>
          <div class="moz-cite-prefix">On 3/4/2015 4:03 PM, Sergey
            Bylokhov wrote:<br>
          </div>
          <blockquote cite="mid:54F702A5.8090304@oracle.com" type="cite">
            <meta content="text/html; charset=utf-8"
              http-equiv="Content-Type">
            <div class="moz-cite-prefix">On 04.03.2015 15:08, Semyon
              Sadetsky wrote:<br>
            </div>
            <blockquote cite="mid:54F6F5A0.2050304@oracle.com"
              type="cite">I think it's more like bug regression test
              policy. Since I'm a novice in the project maybe you or
              somebody can advise me the right process. <br>
              Lets see what we have here: <br>
              The fix is connected to the windows platform native code
              only. It is a platform specific corner case. I would not
              say it contains "magic numbers", those numbers a not magic
              for the native layer. But in the test we call native code
              from java where in truth string parameters maximum lengths
              are not specified. <br>
              I think it make sense to run the test on all other
              platforms test iterating strings lengths up to 1000 or
              more just to ensure that there no similar issues there. We
              can do this once or have an option to switch this scenario
              on. <br>
            </blockquote>
            The goal of the test is to catch all possibly related
            issues. So instead of numbers use ranges, cover all
            platforms if the test don't use platform's specific classes,
            cover all look and feels, automatic test is better than
            manual, make the test generic. But it has of course some
            restrictions like performance and stability. Moreover it
            seems that right now
            <meta http-equiv="content-type" content="text/html;
              charset=utf-8">
            displayMessage/setToolTip are used in the manual tests only.<br>
            <br>
            <blockquote cite="mid:54F6F5A0.2050304@oracle.com"
              type="cite">But I'm not 100% sure that such test scenario
              should be included in the regular regression run because
              sending messages to the system tray is not very fast and
              the scan can take noticeable amount of time. In my opinion
              such issue seeking scenario is reasonable to run time to
              time or as a part of stress testing profile, but it does
              not make sense to run it during the regular regression
              because it tests nothing specific on platforms other than
              Windows and even in Windows there is only one specific
              lengths combination. It's not worth to do this potential
              issue seek it's time expensive but will not bring us a lot
              of value really. <br>
              <br>
              --Semyon <br>
              <br>
              On 3/4/2015 2:13 PM, Sergey Bylokhov wrote: <br>
              <blockquote type="cite">Hi, Semyon. <br>
                I suggest to remove stuff related to windows platform
                from the test. Also it will be good to test some
                reasonable range of data instead of magic constant, wrap
                setTooltip/displayMessage in a loop. <br>
                Please add "tray.remove(trayIcon);" at the end of the
                test, otherwise it can hang, when will be run w/o jtreg.
                <br>
                <br>
                On 03.03.2015 15:32, Semyon Sadetsky wrote: <br>
                <blockquote type="cite">accepted. <br>
                  <a moz-do-not-send="true"
                    class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/semyon-sadetsky/8072769/webrev.03/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.03/</a>
                  <br>
                  <br>
                  <br>
                  On 3/3/2015 1:16 PM, Alexander Scherbatiy wrote: <br>
                  <blockquote type="cite"> <br>
                     Just few comments about the test: <br>
                      - The test sets WindowsLookAndFeel and seems fails
                    on non Windows platforms. <br>
                      - There is the second SystemTray.isSupported()
                    check on line 49. Does it depends on L&F? <br>
                      - The copyright should be updated to 2015. <br>
                    <br>
                     Thanks, <br>
                     Alexandr. <br>
                    <br>
                    On 3/2/2015 4:01 PM, Semyon Sadetsky wrote: <br>
                    <blockquote type="cite">Hello, <br>
                      <br>
                      Test was added. Please review. <br>
                      webrev: <a moz-do-not-send="true"
                        class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/semyon-sadetsky/8072769/webrev.02/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.02/</a>
                      <br>
                      bug: <a moz-do-not-send="true"
                        class="moz-txt-link-freetext"
                        href="https://bugs.openjdk.java.net/browse/JDK-8072769">https://bugs.openjdk.java.net/browse/JDK-8072769</a>
                      <br>
                      <br>
                      <br>
                      On 2/26/2015 10:46 AM, Semyon Sadetsky wrote: <br>
                      <blockquote type="cite">fix updated: <a
                          moz-do-not-send="true"
                          class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/semyon-sadetsky/8072769/webrev.01/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev.01/</a>
                        <br>
                        <br>
                        On 2/24/2015 12:12 PM, Semyon Sadetsky wrote: <br>
                        <blockquote type="cite">Hello, <br>
                          <AWT Dev> [9] review request for
                          8061636: Fix for JDK-7079254 changes behavior
                          of MouseListener, MouseMotionListener <br>
                          please review the fix:<a
                            moz-do-not-send="true"
                            class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/semyon-sadetsky/8072769/webrev/">http://cr.openjdk.java.net/~alexsch/semyon-sadetsky/8072769/webrev/</a>
                          <br>
                          <br>
                          for the issue:<a moz-do-not-send="true"
                            class="moz-txt-link-freetext"
                            href="https://bugs.openjdk.java.net/browse/JDK-8072769">https://bugs.openjdk.java.net/browse/JDK-8072769</a>
                          <br>
                          <br>
                          System tray icon title freezes java <br>
                          <br>
                          This fix contains: <br>
                          fix corner case: <buffer size> ==
                          <length of the string> <br>
                          for two string parameters: <br>
                          1. balloon title string <br>
                          2. balloon text string <br>
                          <br>
                          -- <br>
                          Thanks, <br>
                          <br>
                          Semyon. <br>
                          <br>
                          <br>
                          <br>
                          <br>
                        </blockquote>
                        <br>
                      </blockquote>
                      <br>
                    </blockquote>
                    <br>
                  </blockquote>
                  <br>
                </blockquote>
                <br>
                <br>
              </blockquote>
              <br>
            </blockquote>
            <br>
            <br>
            <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
          </blockquote>
          <br>
        </blockquote>
        <br>
        <br>
        <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
      </blockquote>
      <br>
    </blockquote>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Best regards, Sergey. </pre>
  </body>
</html>