<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Sergey, Kevin,<br>
<br>
This method is called from JFX/interop:<br>
<br>
DropTargetContext.java<br>
- public void addNotify(DropTargetContextPeer dtcp) {<br>
<br>
An accessor is introduced. So, we will have to pick it up in
JFX/interop once the fix is in the ws.<br>
<br>
This means we won't be able to run jfx9 atop of jdk8.<br>
<br>
@Kevin,<br>
<br>
Do you have any concerns with regard to this fact?<br>
<br>
Thanks,<br>
Anton.<br>
<br>
On 25.03.2015 17:35, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5512C7B5.5000009@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hello,<br>
Please review an updated version of the fix.<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8074763/webrev.02">http://cr.openjdk.java.net/~serb/8074763/webrev.02</a><br>
<br>
DropTargetContext.addNotify/removeNotify were renamed and access
was changed to a package private. A necessary methods were added
to the
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
AWTAccessor.<br>
<br>
<br>
18.03.15 23:47, Phil Race wrote:<br>
</div>
<blockquote cite="mid:5509E469.2080106@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">I think its preferable to remove
(hide) the method rather than leave one that<br>
no application code can (or should) call because they can't
provide a parameter<br>
of the required type.<br>
<br>
-phil.<br>
<br>
<br>
On 03/18/2015 09:24 AM, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5509A6A1.3080708@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi, Anton.<br>
The problem is that this method is called when the peer
itself change the information in the DropTargetContext. So
this method works like a setter. I can make this method
private, and get an access to it via accessor. Will it be
better?<br>
<br>
18.03.15 8:27, Anton V. Tarasov wrote:<br>
</div>
<blockquote cite="mid:55099947.2070907@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Sergey,<br>
<br>
The only dependency on JFX/interop is this method in
DropTargetContext.java:<br>
<br>
98 public void addNotify(final Object dtcp) throws
IllegalArgumentException {<br>
<br>
Was that the reason why you left the parameter?<br>
Is it technically possible to retrieve the peer via the
ComponentAccessor.getPeer(component) method where the
component is dropTarget.getComponent()?<br>
<br>
Thanks,<br>
Anton.<br>
<br>
On 16.03.2015 21:30, Sergey Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5507214C.2040208@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
<div class="moz-text-flowed" style="font-family:
-moz-fixed; font-size: 14px;" lang="x-unicode">Hello. <br>
Please review the fix for jdk 9. <br>
There are a number of public API which reference the
unsupported java.awt.
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
dnd.peer interfaces. <br>
<br>
protected
java.awt.dnd.DragSource.createDragSourceContext(java.awt.dnd.peer.DragSourceContextPeer,
...)<br>
public
java.awt.dnd.DragSourceContext(java.awt.dnd.peer.DragSourceContextPeer,
...) constructor<br>
public java.awt.dnd.DropTarget.addNotify(ComponentPeer
peer) and removeNotify(ComponentPeer peer)<br>
public
java.awt.dnd.DropTargetContext.addNotify(DropTargetContextPeer
dtcp)<br>
<br>
There is a decision to remove these references as
described: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://mail.openjdk.java.net/pipermail/awt-dev/2015-February/008924.html">http://mail.openjdk.java.net/pipermail/awt-dev/2015-February/008924.html</a>
<br>
Changes description:<br>
<ul>
<li>DragSource.java, DragSourceContext.java,
DropTarget.java : In all of these methods the peers
are used as a parameters. In most of the cases these
parameters are not necessary, because the peer can
be accessed using the reference to the shared
object(Component/DropTarget etc). Since these
methods can be useful I did not remove them, but
remove one parameter only.</li>
<li>DropTargetContext.java: addNotify() is called when
we cannot get the information about a peer so I
change type of the parameter and documentation of
the method. It seems that these methods
DropTargetContext.addNotify/removeNotify are not
useful and I can change them by private version, but
I don't know which way will be better.</li>
</ul>
Bug: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8074763">https://bugs.openjdk.java.net/browse/JDK-8074763</a><br>
Webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8074763/webrev.01">http://cr.openjdk.java.net/~serb/8074763/webrev.01</a><br>
<br>
<div class="moz-txt-sig"><span class="moz-txt-tag">-- <br>
</span>Best regards, Sergey. <br>
<br>
</div>
</div>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</body>
</html>