<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Sergey, <br>
<br>
thanks for review! <br>
<br>
Could anybody else take a look at the fix? <br>
<br>
Thanks!<br>
Anton.<br>
<br>
<div class="moz-cite-prefix">On 15.05.2015 21:27, Sergey Bylokhov
wrote:<br>
</div>
<blockquote cite="mid:55563AA3.5040409@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi, Anton.<br>
Thanks, the fix looks fine.<br>
</div>
<blockquote cite="mid:555600A4.1030506@oracle.com" type="cite">
I've sent you two suspects, but if this needs to fixed as
well I suggest to make it under another bug. <br>
</blockquote>
ok, I'll take look at it.<br>
<blockquote cite="mid:555600A4.1030506@oracle.com" type="cite"> <br>
Thanks!<br>
Anton.<br>
<br>
<div class="moz-cite-prefix">On 12.05.2015 21:32, Sergey
Bylokhov wrote:<br>
</div>
<blockquote cite="mid:5552473D.4040902@oracle.com" type="cite">
<meta content="text/html; charset=UTF-8"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi, Anton.<br>
The fix looks fine, but I suggest to document the new
resources deallocation policy. I suppose documentation of
loops, CFRetainedResource, etc should be updated.<br>
Also please confirm that all our code follow this rule.<br>
<br>
On 08.05.15 19:52, Anton Nashatyrev wrote:<br>
</div>
<blockquote cite="mid:554CE9BD.9040001@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
Hello, <br>
could you please review the following fix:<br>
<br>
fix: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eanashaty/8068886/webrev.00/">http://cr.openjdk.java.net/~anashaty/8068886/webrev.00/</a><br>
bug: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8068886">https://bugs.openjdk.java.net/browse/JDK-8068886</a><br>
<br>
Problem: the native window pointer is disposed in the
inner AppKit loop, while it is still referenced on the stack
in the native Cocoa method which caused the mentioned inner
loop. When the inner loop is exited Cocoa crashes while
dereferencing this window pointer<br>
<br>
Fix: dispose resources in the main AppKit loop only. For
this a 'dispose message' posted which is processed only on
the main loop. <br>
<br>
Thanks! <br>
Anton. <br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</body>
</html>