<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 27/05/2015 14:48, Sergey Bylokhov wrote:<br>
<blockquote cite="mid:5565CB1B.5070205@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<tt>Hello.<br>
Please review the fix for jdk9.<br>
The usage of getResource() was changed to getResourceAsStream().
Note that before the fix the toolkit.getImage() cached the
image, but it should not be a problem in the new code, because
cursor itself is cached in the </tt><tt>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Cursor.getSystemCustomCursor().<br>
<br>
Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8078658">https://bugs.openjdk.java.net/browse/JDK-8078658</a><br>
Webrev can be found at: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eserb/8078658/webrev.00">http://cr.openjdk.java.net/~serb/8078658/webrev.00</a></tt><br>
</blockquote>
This looks okay to me. I assume existing tests will exercise this
code well.<br>
<br>
A minor comment on the usage of ByteArrayOutputStream is that you
should be able to replace this soon with:<br>
Image image = toolkit.createImage( in.readAllBytes() );<br>
<br>
The readAllBytes method is currently in review on core-libs-dev.<br>
<br>
-Alan.<br>
</body>
</html>