<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello Sergey and Artem,<br>
<br>
After Anton Nashatyrev left the organization, I was assigned to this
bug to complete work on it. Though Sergey approved the 1st version
of the fix, the second approval was not received, and the fix was
not integrated into "jdk9/client". Today I have compiled
"jdk9/client" with the 1st version of the fix for all supported
platforms and:<br>
<br>
1. Verified using the manual test case from the bug description that
<b>the fix resolves the bug</b>.<br>
2. Found out that <b>the regression test
"EventQueuePushAutoshutdown.sh"</b> from the fix <b>always fails
on OS X</b> with the message:<br>
<br>
"Unrecognized system! Darwin"<br>
<br>
because the shell script expects only "SunOS", "Linux", "CYGWIN*",
"Windows_*" versions of OS and does not execute the test on OS X.
Therefore the 2nd version of the fix resolving this issue was
created.<br>
<br>
Could you please review the 2nd version of the fix.<br>
<br>
Webrev (2nd version of the fix):
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~alitvinov/8081485/webrev.01">http://cr.openjdk.java.net/~alitvinov/8081485/webrev.01</a><br>
Webrev (1st version of the fix):
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~anashaty/8081485/webrev.00">http://cr.openjdk.java.net/~anashaty/8081485/webrev.00</a><br>
<br>
The 2nd version of the fix modifies <b>only the regression test
part</b> of the fix:<br>
<br>
Changes in
"test/java/awt/Toolkit/AutoShutdown/EventQueuePush/EventQueuePushAutoshutdown.java":<br>
- "37 private volatile int status = 2;" - Modifier "volatile"
was added, since the variable is accessed from several threads.<br>
- "28 @author Anton Nashatyrev : area=toolkit" - This line was
added.<br>
<br>
Changes in
"test/java/awt/Toolkit/AutoShutdown/EventQueuePush/EventQueuePushAutoshutdown.sh":<br>
- "SunOS", "Linux", "CYGWIN*" were combined in one case of the
switch and "Darwin" was added also to this case.<br>
<br>
Thank you,<br>
Anton<br>
<br>
<div class="moz-cite-prefix">On 7/2/2015 10:52 PM, Sergey Bylokhov
wrote:<br>
</div>
<blockquote cite="mid:55959678.2050405@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi, Anton.<br>
The fix looks fine.<br>
<br>
On 01.07.15 16:07, Anton Nashatyrev wrote:<br>
</div>
<blockquote cite="mid:5593E5F9.205@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hello Artem, Sergey<br>
<br>
thanks for your help with the issue investigation! <br>
<br>
could you please review the following fix:<br>
<br>
fix: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eanashaty/8081485/webrev.00/">http://cr.openjdk.java.net/~anashaty/8081485/webrev.00/</a><br>
bug: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8081485">https://bugs.openjdk.java.net/browse/JDK-8081485</a><br>
<br>
Problem: EventQueue.push() at the very beginning prevents
the app from shutting down automatically <br>
<br>
Reason: the EventQueue.push() first checks if the EDT for
the top EventQeue exists (to transfer it to the new EventQueue)
and then implicitly starts it. <br>
<br>
Fix: do posting of dummy event only in case if the
EventQueue had the EDT<br>
<br>
Thanks! <br>
Anton. <br>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Best regards, Sergey. </pre>
</blockquote>
<br>
</body>
</html>