<div dir="ltr">Too late, I just committed...<div>If people have second thoughts, this change should be watered down rather than reverted anyways, so an independent followup change seems reasonable.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Sep 17, 2015 at 9:10 AM, Phil Race <span dir="ltr"><<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+1 ( ie approved). May need a core-libs reviewer too ?<br>
<br>
-phil.<br>
<br>
On 9/16/2015 10:53 AM, Martin Buchholz wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Webrev regenerated<br>
<a href="http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch</a> <<a href="http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/usr-dt-environment.patch</a>> <br><span class="">
and is now the best kind of change, a pure-deletion change.<br>
<br></span><span class="">
On Wed, Sep 16, 2015 at 9:00 AM, Phil Race <<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a> <mailto:<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>>> wrote:<br>
<br>
That is fine by me. If any one on awt-dev knows of a reason to keep it<br>
they should speak up.<br>
<br>
-phil.<br>
<br>
<br>
On 9/15/15 5:09 PM, Martin Buchholz wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
We would be entirely happy if the environment frobbing code were<br>
to be deleted.<br>
Should I change my code to do that?<br>
<br>
On Tue, Sep 15, 2015 at 3:49 PM, Phil Race<br></span><span class="">
<<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a> <mailto:<a href="mailto:philip.race@oracle.com" target="_blank">philip.race@oracle.com</a>>> wrote:<br>
<br>
I don't understand that original assessment.<br>
Switching to XAWT had no impact on this code except to make<br>
it pointless.<br>
i.e it did not prevent its execution.<br>
<br>
I doubt there is any code left in the JDK that will derive any<br>
benefit from it still being there. All CDE/Motif & Xt related<br>
code is gone.<br>
This should have been removed along with it but was doubtless not<br>
in plain sight to whoever did that.<br>
<br>
So unless I am missing something you could go further and<br>
just delete it.<br>
<br>
-phil.<br>
<br>
<br>
On 9/15/2015 3:13 PM, Martin Buchholz wrote:<br>
<br>
I reported this bug 12 years ago, but it was closed Will<br>
Not Fix, and this year I see java programs crashing<br>
because of it!<br>
This is a partial fix.<br>
<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8136570" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8136570</a><br>
<a href="https://bugs.openjdk.java.net/browse/JDK-4953367" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-4953367</a><br>
<a href="http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~martin/webrevs/openjdk9/usr-dt-environment/</a><br>
<<a href="http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/</a>><br></span>
<<a href="http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Emartin/webrevs/openjdk9/usr-dt-environment/</a>><br>
<br>
<br>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote></div><br></div>