<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""><div class=""><font face="Menlo" class="">Hi All,</font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class="">Kindly review the fix for JDK9.</font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><b class="">Bug: </b></font></div><div class=""><a href="https://bugs.openjdk.java.net/browse/JDK-8147834" class=""><font face="Menlo" class="">https://bugs.openjdk.java.net/browse/JDK-8147834</font></a></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><b class="">Webrev:</b></font></div><div class=""></div><div class=""><font face="Menlo" class=""><a href="http://cr.openjdk.java.net/~mhalder/8147834/webrev.00" class="">http://cr.openjdk.java.net/~mhalder/8147834/webrev.00</a></font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><b class="">Issue: </b></font></div><div class=""><font face="Menlo" class=""><span style="color: rgb(51, 51, 51); line-height: 30px; background-color: rgb(255, 255, 255);" class="">[macosx] KeyEvents for function keys F17, F18, F19 return keyCode 0.</span></font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><b class="">Fix: </b></font></div><div class=""><span class=""><span style="font-family: Menlo;" class="">Added the key codes for function keys F17, F18 and F19 on the MacOS X side. The values of the keys were referred from following file /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h on MacOS X. Fix is also added for function key F20 because F20 key is valid in Java and MacOS X the and need to be supported on MacOS. </span></span><span style="font-family: Menlo;" class="">But this key can’t be tested with the normal USB keyboard because it has function key till F19.</span><span style="font-family: Menlo;" class=""> </span><span class="Apple-tab-span" style="font-family: Menlo; white-space: pre;"> </span><span style="font-family: Menlo;" class=""> </span></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class=""><b class="">Justification of fix:</b></font></div><div class=""><font face="Menlo" class=""><span class="">Key codes of the keys F17, F18, F19 and F20 were not added on the MacOS X side. Fix for key F20 is added because the key should be supported as per the java documentation and the key is a valid function key on MacOS X.</span></font></div><div class=""><font face="Menlo" class=""><b class=""><br class=""></b></font></div><div class=""><font face="Menlo" class=""><b class="">Testing the fix: </b></font></div><div class=""><font face="Menlo" class="">The fix was tested manually using the code present in the description. The automated test case is not ready. While writing the test case it was found that robot.keyPress is failing for function keys F13 to F19 (also will fail for F20). An issue is created for the same problem with jira id <a href="https://bugs.openjdk.java.net/browse/JDK-8149456" class="">https://bugs.openjdk.java.net/browse/JDK-8149456</a>.</font></div><div class=""><font face="Menlo" class=""><br class=""></font></div><div class=""><font face="Menlo" class="">aAutomated test case will be provided in future after fixing issue </font><a href="https://bugs.openjdk.java.net/browse/JDK-8149456" style="font-family: Menlo;" class="">https://bugs.openjdk.java.net/browse/JDK-8149456</a><font face="Menlo" class="">.</font></div><div class=""><br class=""></div><div class=""><font face="Menlo" class="">Regards,</font></div><div class=""><font face="Menlo" class="">Manajit</font></div></body></html>