<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 2/23/2016 12:41 PM, Rajeev Chamyal
wrote:<br>
</div>
<blockquote cite="mid:5c5aae7c-779b-4dbe-8419-bb29d94579b3@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:591161685;
mso-list-type:hybrid;
mso-list-template-ids:-43975096 1074331665 1074331673 1074331675 1074331663 1074331673 1074331675 1074331663 1074331673 1074331675;}
@list l0:level1
{mso-level-text:"%1\)";
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-18.0pt;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0cm;}
ul
{margin-bottom:0cm;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hello Alexandr,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks for the
review.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I have updated
the webrev as per review comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Webrev : <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8145174/webrev.01/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rchamyal/8145174/webrev.01/">http://cr.openjdk.java.net/~rchamyal/8145174/webrev.01/</a></a></span></p>
</div>
</blockquote>
<br>
- splashscreen_sys.c<br>
Is it possible to specify the substring to copy in the snprintf
using "%.*s" format to avoid copying of the file name to
<meta http-equiv="content-type" content="text/html;
charset=windows-1252">
fileNameWithoutExt buffer?<br>
The returned error codes like in the snprintf should be properly
handled.<br>
<br>
- systemScale.c<br>
The J2D_UISCALE property has been added for the testing purposes.
It is better to include it into the getNativeScaleFactor method to
use for splash screens too.<br>
<br>
- the copyright in the test need to be updated to 2016.<br>
<blockquote cite="mid:5c5aae7c-779b-4dbe-8419-bb29d94579b3@default"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN">- It may be
useful to have the same name convention for high-resolution
splash screen on all platforms.<br>
It allows to use only one image.java-scale2x.ext file
instead to have <a moz-do-not-send="true"
href="mailto:image@2x.ext">image@2x.ext</a> on Mac OS X
and name.scale-200.ext on Windows.<br>
</span><span style="color:#1F497D"> For windows we can have
scale factor as float value so it would be difficult to
identify which image name to be displayed.</span></p>
</div>
</blockquote>
I see. It can be an enhancement to support fractional scales
too. For example image.java-scale150%.ext and
image.java-scale144dpi.ext for scale factor 1.5.<br>
<br>
Thanks,<br>
Alexandr.<br>
<blockquote cite="mid:5c5aae7c-779b-4dbe-8419-bb29d94579b3@default"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Rajeev Chamyal<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="color:windowtext;mso-fareast-language:EN-IN"
lang="EN-US">From:</span></b><span
style="color:windowtext;mso-fareast-language:EN-IN"
lang="EN-US"> Alexander Scherbatiy <br>
<b>Sent:</b> 18 February 2016 02:55<br>
<b>To:</b> Rajeev Chamyal; <a
class="moz-txt-link-abbreviated"
href="mailto:awt-dev@openjdk.java.net"><a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></a>;
Sergey Bylokhov<br>
<b>Subject:</b> Re: <AWT Dev> [9] Review request
for JDK-8145174 HiDPI splash screen support on Linux<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">On 12/02/16 16:21, Rajeev Chamyal wrote:<br>
<br>
<span style="font-size:12.0pt;mso-fareast-language:EN-IN"><o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hello All,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Could you please review the following
fix.<o:p></o:p></p>
<p class="MsoNormal">Bug : <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8145174">https://bugs.openjdk.java.net/browse/JDK-8145174</a><o:p></o:p></p>
<p class="MsoNormal">Webrev : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8145174/webrev.00/">http://cr.openjdk.java.net/~rchamyal/8145174/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">This is an enhancement to support HiDPI
splash screen on Linux.<o:p></o:p></p>
<p class="MsoNormal">As a part of this enhancement
implementation to
splashscreen_sys.c::SplashGetScaledImageName method has been
provided based on the GDK_SCALE environment variable set on
unix/linux system.<o:p></o:p></p>
<p class="MsoNormal">The new implementation checks for
GDK_SCALE set on system and returns the scaled image name,
if GDK_SCALE=2 otherwise NULL.<o:p></o:p></p>
<p class="MsoNormal">The naming convention followed for scaled
image is as follows:<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Unscaled image name : image.ext<o:p></o:p></p>
<p class="MsoPlainText">Scaled image name :
image.java-scale2x.ext<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN"><br>
- It may be useful to have the same name convention for
high-resolution splash screen on all platforms.<br>
It allows to use only one image.java-scale2x.ext file
instead to have <a moz-do-not-send="true"
href="mailto:image@2x.ext">image@2x.ext</a> on Mac OS X
and name.scale-200.ext on Windows.<br>
Could you create an enhancement on it and send it to the
review? <br>
<br>
<o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">The automated jtreg test for this is
currently failing due to issues in robot.getPixelColor it is
returning wrong pixel color for GDK_SCALE=2.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Also fixed issues in following files.<o:p></o:p></p>
<p class="MsoListParagraph"
style="text-indent:-18.0pt;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="mso-list:Ignore">1)<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->splashscreen_impl.c::<span
style="font-size:9.5pt;font-family:Consolas;background:white;mso-highlight:white">SplashInit</span>()
was resetting the scaleFactor to 1.<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN">
- SplashSetScaleFactor should not be called from the
SplashGetScaledImageName method because SplashInit has not
been called yet.<br>
- The problem with setting the scale factor in SplashInit
is that it is not clear is the high-resolution splash screen
image provided or not. If the the high-resolution splash
screen is not provided the scale factor should be set to 1.<br>
- The java.c uses the following sequence for the splash
screen initialization:<br>
--------------<br>
scaled_splash_name = DoSplashGetScaledImageName(<br>
jar_name, file_name,
&scale_factor);<br>
DoSplashInit();<br>
DoSplashSetScaleFactor(scale_factor);<br>
DoSplashLoadFile(scaled_splash_name);<br>
--------------<br>
To make the SplashSetScaleFactor method work it should
also be added to the
make/mapfiles/libsplashscreen/mapfile-vers file.<br>
<br>
- There are two codes which detect the scale factor. One is
in the splash screen (getNativeScaleFactor() method)<br>
and another in the AWT
(src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c
file).<br>
Is it possible to move it one code that it will be used
both from splash screen and from AWT?<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoListParagraph"
style="text-indent:-18.0pt;mso-list:l0 level1 lfo2"><!--[if !supportLists]--><span
style="mso-list:Ignore">2)<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->SplashScreen.java::
getBounds fixed the typo.<o:p></o:p></p>
<p class="MsoListParagraph"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Rajeev Chamyal<o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>