<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 3/2/2016 9:50 PM, Rajeev Chamyal wrote:<br>
<blockquote cite="mid:3ec66dc0-b6fe-495a-8c78-5bea018b2a76@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-fareast-language:EN-US;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hello All,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
the updated webrev.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Added a free
call for duplicate file name in splashscreen_sys.c ::
SplashGetScaledImageName<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8145173/webrev.02/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rchamyal/8145173/webrev.02/">http://cr.openjdk.java.net/~rchamyal/8145173/webrev.02/</a></a></span></p>
</div>
</blockquote>
<br>
awt_Win32GraphicsDevice.cpp<br>
656 dpiX = GetScreenDpi(GetMonitor());<br>
657 if (dpiX > 0) {<br>
658 dpiX = dpiX >= 96 ? dpiX / 96 : dpiX;<br>
659 SetScale(dpiX, dpiX);<br>
<br>
The Windows HiDPI graphics support was designed to handle both DPI X
and Y scales. The GetScreenDpi should return both values to be used
in SetScale method.<br>
<br>
systemScale.cpp<br>
<pre> 38 float scale = -2.0f;
39 if (scale == -2) {
Initially the scale variable was defined as static to avoid rereading the J2D_UISCALE test variable each time.
It is better to preserve the "// for debug purposes" comment also.
MultiResolutionSplashTest.java
+ scaleFactor = (float)((SunGraphics2D) g).surfaceData.getDefaultScaleX();
Now it is possible to get the the scale factor using GraphicsEnvironment.getLocalGraphicsEnvironment().getDefaultScreenDevice().getDefaultConfiguration().getDefaultTransform().getScaleX()
</pre>
Thanks,<br>
Alexandr.<br>
<br>
<blockquote cite="mid:3ec66dc0-b6fe-495a-8c78-5bea018b2a76@default"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Rajeev Chamyal<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:EN-IN" lang="EN-US">From:</span></b><span
style="mso-fareast-language:EN-IN" lang="EN-US"> Rajeev
Chamyal <br>
<b>Sent:</b> 01 March 2016 15:45<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; Sergey Bylokhov;
Alexander Scherbatiy<br>
<b>Subject:</b> RE: <AWT Dev> [9] Review request
for JDK-8145173 HiDPI splash screen support on Windows<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hello All,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Gentle
reminder.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
the updated webrev.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8145173/webrev.01/">http://cr.openjdk.java.net/~rchamyal/8145173/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Rajeev Chamyal<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="mso-fareast-language:EN-IN" lang="EN-US">From:</span></b><span
style="mso-fareast-language:EN-IN" lang="EN-US"> Rajeev
Chamyal <br>
<b>Sent:</b> 16 February 2016 16:01<br>
<b>To:</b> <a moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
Sergey Bylokhov; Alexander Scherbatiy<br>
<b>Subject:</b> <AWT Dev> [9] Review request for
JDK-8145173 HiDPI splash screen support on Windows<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hello All,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Could you please review the following fix.<o:p></o:p></p>
<p class="MsoNormal">Bug : <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8145173">https://bugs.openjdk.java.net/browse/JDK-8145173</a><o:p></o:p></p>
<p class="MsoNormal">Webrev : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8145173/webrev.00/">http://cr.openjdk.java.net/~rchamyal/8145173/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This is an enhancement to support HiDPI
splash screen on windows.<o:p></o:p></p>
<p class="MsoNormal">As a part of this enhancement
implementation to splashscreen_sys.c::SplashGetScaledImageName
method has been provided.<o:p></o:p></p>
<p class="MsoNormal">System dpi and scale factor are used to
determine the scaled image name. Dpi value is read using
GetDpiForMonitor API on Windows 8 and GetDesktopDpi API on
Windows 7.<o:p></o:p></p>
<p class="MsoNormal">Scale factor is calculated from the dpi
value.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The naming convention followed for scaled
image name is as follows:<o:p></o:p></p>
<p class="MsoNormal">Refer : <a moz-do-not-send="true"
href="https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh965325.aspx">https://msdn.microsoft.com/en-us/library/windows/apps/xaml/hh965325.aspx</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Unscaled image name : image.ext<o:p></o:p></p>
<p class="MsoPlainText">Scaled image name : image.scale-<dpi
value>.<em><span
style="font-family:"Calibri",sans-serif">ext</span></em><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Rajeev Chamyal<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>