<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Thanks, Alexander.<div class="">Can you also review it?</div><div class=""><br class=""></div><div class="">-hendrik<br class=""><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On Mar 11, 2016, at 19:06, Alexander Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
<br class="">
I have uploaded the webrev to the <a href="http://cr.openjdk.java.net" class="">cr.openjdk.java.net</a>:<br class="">
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.00/">http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.00/</a><br class="">
<br class="">
Thanks,<br class="">
Alexandr.<br class="">
<br class="">
<div class="moz-cite-prefix">On 11/03/16 20:10, Hendrik Schreiber
wrote:<br class="">
</div>
<blockquote cite="mid:36184957-6682-4F71-BDD4-2EA35BE49209@tagtraum.com" type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
Hey there,
<div class=""><br class="">
</div>
<div class="">I would very much appreciate a review (and a
sponsor) for this JDK 8u fix.</div>
<div class=""><br class="">
</div>
<div class="">Thanks so much!</div>
<div class=""><br class="">
</div>
<div class="">-hendrik</div>
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Mar 7, 2016, at 16:47, Hendrik Schreiber
<<a moz-do-not-send="true" href="mailto:hs@tagtraum.com" class="">hs@tagtraum.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;" class="">Hey
there,
<div class=""><br class="">
</div>
<div class="">Could someone please review this fix for
JDK8u.</div>
<div class=""><br class="">
</div>
<div class="">Bug:</div>
<div class=""><a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8151385" class="">https://bugs.openjdk.java.net/browse/JDK-8151385</a></div>
<div class=""><br class="">
</div>
<div class="">Webrev:</div>
<div class=""><a moz-do-not-send="true" href="https://www.beatunes.com/download/webrev-8151385.zip" class="">https://www.beatunes.com/download/webrev-8151385.zip</a></div>
<div class=""><br class="">
</div>
<div class="">Issue:</div>
<div class="">On Windows 10 with a HiDPI display, the
icons in JOptionsPanes are only partially displayed
(screenshot in the bug report).</div>
<div class=""><br class="">
</div>
<div class="">Fix:</div>
<div class="">Changed the methods that create
BufferedImages from Windows bitmaps so the actual
bitmap size is taken into account.</div>
<div class="">Background: Windows 10 delivers
differently sized bitmaps based on display resolution.</div>
<div class=""><br class="">
</div>
<div class="">Automated Test:</div>
<div class="">The error icon displayed by JOptionsPanes
is round and as such the pixels in all four corners
are identical (transparent).</div>
<div class="">If the error occurs, at least the pixel in
the lower right corner is not the same as the one on
the upper left corner. The test checks, that the
pixels in all four corners are identical. This makes
sure the test also succeeds on standard DPI displays.</div>
<div class=""><br class="">
</div>
<div class="">For the test to actually fail (without the
fix), this test needs to be run on a Windows 10 system
with a HiDPI display.</div>
<div class=""><br class="">
</div>
<div class="">I have tested this on Windows 7 and
Windows 10.</div>
<div class="">I have not tested it on Vista or Windows
8.x.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class=""><br class="">
</div>
<div class="">-hendrik</div>
<div class=""><br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></div></div></body></html>