<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Looks good.<br>
<br>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 3/13/2016 12:17 AM, Ambarish Rapte
wrote:<br>
</div>
<blockquote cite="mid:2c62ea24-9315-4a4c-b7a8-d5056ca75103@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:349375648;
mso-list-type:hybrid;
mso-list-template-ids:-50443832 -170240236 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.75in;
text-indent:-.25in;}
@list l0:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1
{mso-list-id:937179123;
mso-list-type:hybrid;
mso-list-template-ids:-654273934 390781714 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l1:level1
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.75in;
text-indent:-.25in;}
@list l1:level2
{mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l1:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2
{mso-list-id:1265193725;
mso-list-type:hybrid;
mso-list-template-ids:-979984902 -363673222 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l2:level1
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:.75in;
text-indent:-.25in;}
@list l2:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
margin-left:1.25in;
text-indent:-.25in;}
@list l2:level3
{mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level4
{mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level5
{mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level6
{mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level7
{mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level8
{mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;}
@list l2:level9
{mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi All,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
I have updated the webrev with a change in Text Area code.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
There was an issue with webrev.01 that, In Text Area last
line does not get selected while selecting vertically
downards.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
Please review the updated webrev.02<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8149636/webrev.02/">http://cr.openjdk.java.net/~arapte/8149636/webrev.02/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ambarish<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Ambarish Rapte <br>
<b>Sent:</b> Friday, March 11, 2016 7:56 PM<br>
<b>To:</b> Ambarish Rapte; Semyon Sadetsky; Prasanta
Sadhukhan; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> RE: <AWT Dev> Review Request For
8149636: TextField flicker & over scroll when
selection scrolls beyond the bounds of TextField.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi, <o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:.5in"><span
style="color:#1F497D">Gentle reminder for review…<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ambarish<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Ambarish Rapte <br>
<b>Sent:</b> Tuesday, March 08, 2016 9:19 PM<br>
<b>To:</b> Semyon Sadetsky; Prasanta Sadhukhan; <a
moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net"><a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></a><br>
<b>Subject:</b> Re: <AWT Dev> Review Request For
8149636: TextField flicker & over scroll when
selection scrolls beyond the bounds of TextField.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Semyon,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
Please review the webrev.01, updated as per review comments<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8149636/webrev.01/">http://cr.openjdk.java.net/~arapte/8149636/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:.5in"><span
style="color:#1F497D">Changes:<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l0 level1
lfo2"><!--[if !supportLists]--><span style="color:#1F497D"><span
style="mso-list:Ignore">1.<span style="font:7.0pt
"Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">Added similar changes for TextArea.<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l0 level1
lfo2"><!--[if !supportLists]--><span style="color:#1F497D"><span
style="mso-list:Ignore">2.<span style="font:7.0pt
"Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">Added automatic test to test over
scroll.<o:p></o:p></span></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l0 level1
lfo2"><!--[if !supportLists]--><span style="color:#1F497D"><span
style="mso-list:Ignore">3.<span style="font:7.0pt
"Times New Roman""> </span></span></span><!--[endif]--><span
style="color:#1F497D">Text Field Flicker test is manual, as
cannot be automated.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ambarish<o:p></o:p></span></p>
<p class="MsoNormal" style="text-indent:.5in"><span
style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Semyon Sadetsky <br>
<b>Sent:</b> Friday, March 04, 2016 11:57 AM<br>
<b>To:</b> Ambarish Rapte; Prasanta Sadhukhan; <a
moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net"><a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></a><br>
<b>Subject:</b> Re: <AWT Dev> Review Request For
8149636: TextField flicker & over scroll when
selection scrolls beyond the bounds of TextField.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Ambarish,<br>
<br>
the first point is not valid. Please, ignore it.<br>
<br>
--Semyon<o:p></o:p></p>
<div>
<p class="MsoNormal">On 3/1/2016 11:14 AM, Semyon Sadetsky
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Ambarish,<br>
<br>
- The over scroll remains after the proposed fix.<br>
<br>
- The bug is a regression of 7092551 and should be labeled
correspondingly.<br>
<br>
- An automatic test may and should be provided with the fix.<br>
<br>
- The same issue existing in the TextArea should be fixed as
well.<br>
<br>
--Semyon<o:p></o:p></p>
<div>
<p class="MsoNormal">On 2/11/2016 12:23 PM, Ambarish Rapte
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> Please review the fix
for JDK9,<o:p></o:p></p>
<p class="MsoNormal"> Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8149636"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8149636">https://bugs.openjdk.java.net/browse/JDK-8149636</a></a><o:p></o:p></p>
<p class="MsoNormal"> Webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8149636/webrev.00/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8149636/webrev.00/">http://cr.openjdk.java.net/~arapte/8149636/webrev.00/</a></a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Issue:<o:p></o:p></p>
<p class="MsoNormal"> While scrolling with
selection, when mouse is dragged outside the bounds of
TextField,<o:p></o:p></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l1
level1 lfo4"><!--[if !supportLists]--><span
style="mso-list:Ignore">a.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->TextField
flickering is observed<o:p></o:p></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l1
level1 lfo4"><!--[if !supportLists]--><span
style="mso-list:Ignore">b.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->TextField
over scrolls on right. Text gets hidden on left side even
when no scroll is needed.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Cause:<o:p></o:p></p>
<p class="MsoListParagraph"
style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.75in;text-indent:-.25in;mso-list:l2
level1 lfo6"><!--[if !supportLists]--><span
style="mso-list:Ignore">a.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->Flicker
– <br>
For simulating scroll, scroll bar information is used.<br>
To get correct scroll info, scroll bar should be visible.<br>
Showing and hiding of scroll bar causes the flickering.<o:p></o:p></p>
<p class="MsoListParagraph"
style="margin-left:.75in;text-indent:-.25in;mso-list:l2
level1 lfo6"><!--[if !supportLists]--><span
style="mso-list:Ignore">b.<span style="font:7.0pt
"Times New Roman""> </span></span><!--[endif]-->Over
Scroll – <o:p></o:p></p>
<p class="MsoListParagraph" style="margin-left:.75in">The
scrolling logic scrolled the textField in units of half
the si.nPage. i.e. (si.inPage / 2) maximum till si.nMax,<br>
Which causes the over scroll.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Fix:<o:p></o:p></p>
<p class="MsoNormal"> ES_AUTOHSCROLL set for
the TextField enables the automatic horizontal scrolling,
so we need not add code for scrolling.<o:p></o:p></p>
<p class="MsoNormal"> Only selection should
be updated as the mouse moves.<o:p></o:p></p>
<p class="MsoNormal"> Hence removed the code
to related to SendMessage( WM_HSCROLL,…) i.e. scrolling<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Verification:<o:p></o:p></p>
<p class="MsoNormal"> Manually Verified that
textField editing / selection / copy / paste works fine.<o:p></o:p></p>
<p class="MsoNormal"> No Jtreg, JCK tests
related to TextField fail due to this change.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> Updated an existing
test <b>ScrollSelectionTest.java </b>to test the
scenarios mentioned in the bug.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Ambarish<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><o:p> </o:p></span></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>