<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 3/18/2016 6:09 AM, Hendrik Schreiber wrote:<br>
<blockquote
cite="mid:337E07D9-EC25-4BE7-B387-F11473A8BB26@tagtraum.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
On Mar 16, 2016, at 06:25, Alexandr Scherbatiy <<a
moz-do-not-send="true"
href="mailto:alexandr.scherbatiy@oracle.com" class=""><a class="moz-txt-link-abbreviated" href="mailto:alexandr.scherbatiy@oracle.com">alexandr.scherbatiy@oracle.com</a></a>>
wrote:<br class="">
<div>
<blockquote type="cite" class=""><br
class="Apple-interchange-newline">
<div class="">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class=""> <br
class="">
The JDK fixes should be pushed to the JDK 9 first and
then be back-ported to JDK 8.<br class="">
<br class="">
Could you prepare the fix for JDK 9?<br class="">
</div>
</div>
</blockquote>
<div><br class="">
</div>
<div>Hi Alexandr,</div>
<div><br class="">
</div>
<div>I've created a patch for JDK9. You can find it at <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ehschreiber/8151385/webrev.00/"
class=""><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~hschreiber/8151385/webrev.00/">http://cr.openjdk.java.net/~hschreiber/8151385/webrev.00/</a></a> (I
hope, I created the webrev the right way). It contains a
suitable test.</div>
<div><br class="">
</div>
<div>This patch also contains the changes I suggested in <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8149453"
class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8149453">https://bugs.openjdk.java.net/browse/JDK-8149453</a></a> (because
the fixes overlap to a degree). I made sure they compile, but
didn’t do any further testing (lack of time). Perhaps, since
you are already working on this, you can try it out and, if
you deem it appropriate, add a test for the upFolder/newFolder
etc. buttons.</div>
</div>
</blockquote>
For some reasons the native getIconBits() method returns size 16
for both small and large icons which leads to the AOBE in the
BufferedImage.setRGB() methods.<br>
I will try to investigate it deeper.<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<blockquote
cite="mid:337E07D9-EC25-4BE7-B387-F11473A8BB26@tagtraum.com"
type="cite">
<div>
<div><br class="">
</div>
<div>Cheers,</div>
<div><br class="">
</div>
<div>-hendrik</div>
<div><br class="">
</div>
<blockquote type="cite" class="">
<div class="">
<div bgcolor="#FFFFFF" text="#000000" class=""><br class="">
<br class="">
On 3/12/2016 3:23 AM, Hendrik Schreiber wrote:<br class="">
<blockquote
cite="mid:CBC1EF8D-5853-42F8-B416-A6364D5BB8BD@tagtraum.com"
type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
Thanks, Alexander.
<div class="">Can you also review it?</div>
<div class=""><br class="">
</div>
<div class="">-hendrik<br class="">
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Mar 11, 2016, at 19:06,
Alexander Scherbatiy <<a
moz-do-not-send="true"
href="mailto:alexandr.scherbatiy@oracle.com"
class=""><a class="moz-txt-link-abbreviated" href="mailto:alexandr.scherbatiy@oracle.com">alexandr.scherbatiy@oracle.com</a></a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta content="text/html;
charset=windows-1252"
http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
<br class="">
I have uploaded the webrev to the <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/"
class="">cr.openjdk.java.net</a>:<br
class="">
<a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ealexsch/hendrik.schreiber/8151385/webrev.00/">http://cr.openjdk.java.net/~alexsch/hendrik.schreiber/8151385/webrev.00/</a><br
class="">
<br class="">
Thanks,<br class="">
Alexandr.<br class="">
<br class="">
<div class="moz-cite-prefix">On 11/03/16
20:10, Hendrik Schreiber wrote:<br
class="">
</div>
<blockquote
cite="mid:36184957-6682-4F71-BDD4-2EA35BE49209@tagtraum.com"
type="cite" class="">
<meta http-equiv="Content-Type"
content="text/html;
charset=windows-1252" class="">
Hey there,
<div class=""><br class="">
</div>
<div class="">I would very much appreciate
a review (and a sponsor) for this JDK 8u
fix.</div>
<div class=""><br class="">
</div>
<div class="">Thanks so much!</div>
<div class=""><br class="">
</div>
<div class="">-hendrik</div>
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On Mar 7, 2016, at
16:47, Hendrik Schreiber <<a
moz-do-not-send="true"
class="moz-txt-link-abbreviated"
href="mailto:hs@tagtraum.com"><a class="moz-txt-link-abbreviated" href="mailto:hs@tagtraum.com">hs@tagtraum.com</a></a>>
wrote:</div>
<br
class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type"
content="text/html;
charset=windows-1252" class="">
<div style="word-wrap: break-word;
-webkit-nbsp-mode: space;
-webkit-line-break:
after-white-space;" class="">Hey
there,
<div class=""><br class="">
</div>
<div class="">Could someone
please review this fix for
JDK8u.</div>
<div class=""><br class="">
</div>
<div class="">Bug:</div>
<div class=""><a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8151385"
class=""><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8151385">https://bugs.openjdk.java.net/browse/JDK-8151385</a></a></div>
<div class=""><br class="">
</div>
<div class="">Webrev:</div>
<div class=""><a
moz-do-not-send="true"
href="https://www.beatunes.com/download/webrev-8151385.zip"
class=""><a class="moz-txt-link-freetext" href="https://www.beatunes.com/download/webrev-8151385.zip">https://www.beatunes.com/download/webrev-8151385.zip</a></a></div>
<div class=""><br class="">
</div>
<div class="">Issue:</div>
<div class="">On Windows 10 with
a HiDPI display, the icons in
JOptionsPanes are only
partially displayed
(screenshot in the bug
report).</div>
<div class=""><br class="">
</div>
<div class="">Fix:</div>
<div class="">Changed the
methods that create
BufferedImages from Windows
bitmaps so the actual bitmap
size is taken into account.</div>
<div class="">Background:
Windows 10 delivers
differently sized bitmaps
based on display resolution.</div>
<div class=""><br class="">
</div>
<div class="">Automated Test:</div>
<div class="">The error icon
displayed by JOptionsPanes is
round and as such the pixels
in all four corners are
identical (transparent).</div>
<div class="">If the error
occurs, at least the pixel in
the lower right corner is not
the same as the one on the
upper left corner. The test
checks, that the pixels in all
four corners are identical.
This makes sure the test also
succeeds on standard DPI
displays.</div>
<div class=""><br class="">
</div>
<div class="">For the test to
actually fail (without the
fix), this test needs to be
run on a Windows 10 system
with a HiDPI display.</div>
<div class=""><br class="">
</div>
<div class="">I have tested this
on Windows 7 and Windows 10.</div>
<div class="">I have not tested
it on Vista or Windows 8.x.</div>
<div class=""><br class="">
</div>
<div class="">Thanks,</div>
<div class=""><br class="">
</div>
<div class="">-hendrik</div>
<div class=""><br class="">
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
<br class="">
</div>
</div>
</blockquote>
</div>
<br class="">
</blockquote>
<br>
</body>
</html>