<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Semyon,<div class=""><br class=""></div><div class="">Thank you for the review comment. </div><div class="">The test can’t be automated because of the following reasons:</div><div class=""><br class=""></div><div class="">On Mac OS X and Windows:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>There is no key code for the right ALT button (no right key codes for ALT, SHIFT, COMMAND).<span class="Apple-tab-span" style="white-space:pre"> </span>robot.keyPress(KeyEvent.VK_ALT) will press the left ALT key.</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>It is not possible to press the right ALT key using robot. </div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>Hence Alt-Gr modifier won’t be set using robot.</div><div class=""><br class=""></div><div class="">On Linux:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>The Alt graph is configurable.</div><div class=""><br class=""></div><div class="">Regards,</div><div class="">Manajit</div><div class=""><br class=""></div><div class=""><br class=""></div><div class=""><div><blockquote type="cite" class=""><div class="">On 12-Apr-2016, at 9:07 pm, Semyon Sadetsky <<a href="mailto:semyon.sadetsky@oracle.com" class="">semyon.sadetsky@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
<meta content="text/html; charset=windows-1252" http-equiv="Content-Type" class="">
<div bgcolor="#FFFFFF" text="#000000" class="">
Hi Manajit,<br class="">
<br class="">
The fix itself is OK. <br class="">
Why the test cannot be automated?<br class="">
<br class="">
--Semyon<br class="">
<br class="">
<div class="moz-cite-prefix">On 4/12/2016 1:46 PM, Manajit Halder
wrote:<br class="">
</div>
<blockquote cite="mid:E1972932-5B27-4C21-A725-030431099550@oracle.com" type="cite" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
Hi All,<br class="">
<br class="">
Gentle remainder. Please review the changes.<br class="">
<br class="">
Thanks,<br class="">
Manajit
<div class=""><br class="">
<div class=""><br class="">
<div class="">
<blockquote type="cite" class="">
<div class="">On 07-Apr-2016, at 1:48 pm, Manajit Halder
<<a moz-do-not-send="true" href="mailto:manajit.halder@oracle.com" class="">manajit.halder@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252" class="">
<div style="word-wrap: break-word; -webkit-nbsp-mode:
space; -webkit-line-break: after-white-space;" class="">
<div style="line-height: 16px;" class=""><span style="color: rgb(0, 30, 87);" class=""><font class="" size="2" face="Menlo">Hi All,</font></span></div>
<div class="">
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><br class="">
</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo">Kindly
review the fix for JDK9.</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><br class="">
</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><b class="">Bug</b>: </font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" face="Menlo"><span style="line-height: normal;" class=""> <span class="Apple-tab-span" style="white-space:pre"> </span></span><a moz-do-not-send="true" href="https://bugs.openjdk.java.net/browse/JDK-8151136" style="line-height: normal;" class=""></a><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8151136">https://bugs.openjdk.java.net/browse/JDK-8151136</a></font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><u class=""><br class="">
</u></font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><b class="">Webrev</b>: </font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><span class="Apple-tab-span" style="white-space:pre"> </span></font><font style="color: purple;" class="" size="2" face="Menlo"><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Earapte/manajit/8151136/webrev.00/" class="">http://cr.openjdk.java.net/~arapte/manajit/8151136/webrev.00/</a></font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><br class="">
</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><b class="">Issue: </b></font></div>
<div class=""><font class="" size="2" color="#001e57" face="Menlo"><span style="line-height: 16px;" class="">[macosx]
According to the description,the case is
failed (AltGraph key is not supported on OS
X).</span></font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><br class="">
</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><b class="">Cause: </b></font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" face="Menlo"><span style="line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>On
OS X AltGraph functionality was not
implemented. </span></font></div>
<div style="line-height: 16px;" class=""><span style="font-family: Menlo; line-height: normal;" class=""><br class="">
</span></div>
<div style="line-height: 16px;" class=""><span style="font-family: Menlo; line-height: normal;" class=""><b class="">Information on AltGraph Key
on OS X:</b></span></div>
<div style="line-height: 16px;" class=""><span style="font-family: Menlo; line-height: normal;" class=""><span class="Apple-tab-span" style="white-space:pre"> </span>On
OS X there is no key defined for AltGraph on the
Keyboard. </span><span style="font-family:
Menlo; line-height: normal;" class="">As per
wikipedia link </span><a moz-do-not-send="true" href="https://en.wikipedia.org/wiki/AltGr_key" style="font-family: Menlo; line-height: normal;" class="">https://en.wikipedia.org/wiki/AltGr_key</a><span style="font-family: Menlo; line-height: normal;" class=""> Option key has function similar to the
AltGr key. </span><span style="font-family:
Menlo; line-height: normal;" class="">But Option
is also Alt key on OS X. </span></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><br class="">
</font></div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo"><b class="">Fix: </b></font></div>
<div class=""><font class="" size="2" face="Menlo"><span class="Apple-tab-span" style="line-height: 16px; white-space: pre;"> </span><span style="line-height: 16px;" class="">Right Option
key is defined to behave as AltGraph key on OS
X. AltGraph functionality is added for left
key. </span></font></div>
<div style="line-height: 16px;" class="">
<div class=""><br class="">
</div>
</div>
<div style="line-height: 16px;" class=""><font class="" size="2" color="#001e57" face="Menlo">Regards,<br class="">
Manajit</font></div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</blockquote>
<br class="">
</div>
</div></blockquote></div><br class=""></div></body></html>