<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 4/27/2016 7:40 PM, Rajeev Chamyal wrote:<br>
<blockquote cite="mid:dd34afa3-4e22-4072-ba9e-a749ec285c7d@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;
mso-fareast-language:EN-US;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;
color:black;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hello Alexandr,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
the updated fix.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.01/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rchamyal/8151787/webrev.01/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.01/</a></a></span></p>
</div>
</blockquote>
<br>
162 fileName2x = findScaledImageName(fileName, dotIndex,
@"@2x");<br>
163 if(fileName2x != nil && ![[NSFileManager
defaultManager]<br>
164 fileExistsAtPath:
fileName2x]) {<br>
165 fileName2x = findScaledImageName(fileName,
dotIndex, @".java-scale2x");<br>
166 }<br>
<br>
- Will the java-scale2x image be chosen if fileName2x is nil on the
line 163?<br>
- Could you add the use case where both @2x and java-scale2x are
provided and @2x is chosen in the test?<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<blockquote cite="mid:dd34afa3-4e22-4072-ba9e-a749ec285c7d@default"
type="cite">
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Rajeev Chamyal<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span
style="color:windowtext;mso-fareast-language:EN-IN"
lang="EN-US">From:</span></b><span
style="color:windowtext;mso-fareast-language:EN-IN"
lang="EN-US"> Alexandr Scherbatiy <br>
<b>Sent:</b> 26 April 2016 14:22<br>
<b>To:</b> Rajeev Chamyal; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
Sergey Bylokhov<br>
<b>Subject:</b> Re: <AWT Dev> [9] Review request
for JDK-8151787 Unify the HiDPI splash screen image
naming convention<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">On 4/26/2016 11:13 AM, Rajeev Chamyal
wrote:<br>
<br>
<span style="font-size:12.0pt;mso-fareast-language:EN-IN"><o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hello All,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Could you please review the following
fix.<o:p></o:p></p>
<p class="MsoNormal">Bug : <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8151787">https://bugs.openjdk.java.net/browse/JDK-8151787</a>
<o:p></o:p></p>
<p class="MsoNormal">Webrev : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.00/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/</a>
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">This is a small enhancement to support
similar HiDPI splash screen image name convention on all
platforms.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Currently we have different naming
convention for scaled images on different platforms.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Image name : image.ext<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Scaled image names:<o:p></o:p></p>
<p class="MsoNormal">Windows : image.scale-dpiValue.ext <br>
Linux : image.java-scale2x.ext <br>
MAC <a moz-do-not-send="true" href="mailto:image@2x.ext">image@2x.ext</a>
<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">After the fix naming convention on Mac
and Linux would be :<o:p></o:p></p>
<p class="MsoNormal">Image name : image.ext<o:p></o:p></p>
<p class="MsoPlainText">Scaled image name :
image.java-scale2x.<em><span
style="font-family:"Calibri",sans-serif">ext</span></em><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN"> Both name
conventions @2x and java-scale2x should be supported on Mac
OS X.<br>
The more specific one @2x should be checked in the first
place and the java-scale2x in the second.<br>
<br>
Thanks,<br>
Alexandr.<i><br>
<em> </em><br>
<br>
</i><o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Naming convention on windows :<o:p></o:p></p>
<p class="MsoNormal">Image name : image.ext<o:p></o:p></p>
<p class="MsoPlainText">Scaled image name :
image.java-scale<dpi value>.<em><span
style="font-family:"Calibri",sans-serif">ext</span></em><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Rajeev Chamyal<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman",serif;mso-fareast-language:EN-IN"><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>