<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma",sans-serif;
color:black;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma",sans-serif;
color:black;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle27
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-IN link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Hello All,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Please review the updated webrev.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'><a href="http://cr.openjdk.java.net/~rchamyal/8151787/webrev.03/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.03/</a><o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Added launcher.properties file to webrev.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Updated the command line description for -splash:<imagepath> option.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'>Rajeev Chamyal<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='color:windowtext'>From:</span></b><span lang=EN-US style='color:windowtext'> Ambarish Rapte <br><b>Sent:</b> 02 May 2016 12:01<br><b>To:</b> Alexander Scherbatiy; Rajeev Chamyal; awt-dev@openjdk.java.net; Sergey Bylokhov<br><b>Subject:</b> RE: <AWT Dev> [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Hi Rajeev,<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> The fix looks good to me.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Ambarish<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:windowtext'>From:</span></b><span lang=EN-US style='font-size:10.0pt;font-family:"Tahoma",sans-serif;color:windowtext'> Alexander Scherbatiy <br><b>Sent:</b> Friday, April 29, 2016 5:18 PM<br><b>To:</b> Rajeev Chamyal; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; Sergey Bylokhov<br><b>Subject:</b> Re: <AWT Dev> [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention<o:p></o:p></span></p></div></div><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US><br>The fix looks good to me.<br><br>Thanks,<br>Alexandr.<o:p></o:p></span></p><div><p class=MsoNormal><span lang=EN-US>On 29/04/16 13:49, Rajeev Chamyal wrote:<o:p></o:p></span></p></div><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Hello Alexandr,</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Please review the updated fix.</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'><a href="http://cr.openjdk.java.net/~rchamyal/8151787/webrev.02/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.02/</a></span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'>- Will the java-scale2x image be chosen if fileName2x is nil on the line 163?</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:5.0pt;margin-right:36.0pt;margin-bottom:0cm;margin-left:36.0pt;margin-bottom:.0001pt'><span lang=EN-US style='color:#1F497D'>fileName2x cannot be nil SplashGetScaledImageName is called only if a not null value is passed in filename and </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:5.0pt;margin-right:36.0pt;margin-bottom:0cm;margin-left:36.0pt;margin-bottom:.0001pt'><span lang=EN-US style='color:#1F497D'>other parameters to new method findScaledImageName are constants.</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal style='mso-margin-top-alt:5.0pt;margin-right:36.0pt;margin-bottom:0cm;margin-left:36.0pt;margin-bottom:.0001pt'><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'>- Could you add the use case where both @2x and java-scale2x are provided and @2x is chosen in the test?</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>I have updated the test as suggested.</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Regards,</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Rajeev Chamyal</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='color:windowtext'>From:</span></b><span lang=EN-US style='color:windowtext'> Alexandr Scherbatiy <br><b>Sent:</b> 28 April 2016 00:20<br><b>To:</b> Rajeev Chamyal; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; Sergey Bylokhov<br><b>Subject:</b> Re: <AWT Dev> [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention</span><span lang=EN-US><o:p></o:p></span></p></div></div><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US>On 4/27/2016 7:40 PM, Rajeev Chamyal wrote:<br><br><o:p></o:p></span></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Hello Alexandr,</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Please review the updated fix.</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><a href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.01/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.01/</a><o:p></o:p></span></p></blockquote><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US style='font-size:12.0pt'><br> 162 fileName2x = findScaledImageName(fileName, dotIndex, @"@2x");<br> 163 if(fileName2x != nil && ![[NSFileManager defaultManager]<br> 164 fileExistsAtPath: fileName2x]) {<br> 165 fileName2x = findScaledImageName(fileName, dotIndex, @".java-scale2x");<br> 166 }<br><br>- Will the java-scale2x image be chosen if fileName2x is nil on the line 163?<br>- Could you add the use case where both @2x and java-scale2x are provided and @2x is chosen in the test?<br><br>Thanks,<br>Alexandr.<br><br><br></span><span lang=EN-US><o:p></o:p></span></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Regards,</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'>Rajeev Chamyal</span><span lang=EN-US><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='color:#1F497D'> </span><span lang=EN-US><o:p></o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='color:windowtext'>From:</span></b><span lang=EN-US style='color:windowtext'> Alexandr Scherbatiy <br><b>Sent:</b> 26 April 2016 14:22<br><b>To:</b> Rajeev Chamyal; </span><span lang=EN-US><a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a></span><span lang=EN-US style='color:windowtext'>; Sergey Bylokhov<br><b>Subject:</b> Re: <AWT Dev> [9] Review request for JDK-8151787 Unify the HiDPI splash screen image naming convention</span><span lang=EN-US><o:p></o:p></span></p></div></div><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US>On 4/26/2016 11:13 AM, Rajeev Chamyal wrote:<br><br><br><o:p></o:p></span></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-US>Hello All,<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Could you please review the following fix.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Bug : <a href="https://bugs.openjdk.java.net/browse/JDK-8151787">https://bugs.openjdk.java.net/browse/JDK-8151787</a> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Webrev : <a href="http://cr.openjdk.java.net/%7Erchamyal/8151787/webrev.00/">http://cr.openjdk.java.net/~rchamyal/8151787/webrev.00/</a> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>This is a small enhancement to support similar HiDPI splash screen image name convention on all platforms.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Currently we have different naming convention for scaled images on different platforms.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Image name : image.ext<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Scaled image names:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Windows : image.scale-dpiValue.ext <br>Linux : image.java-scale2x.ext <br>MAC <a href="mailto:image@2x.ext">image@2x.ext</a> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>After the fix naming convention on Mac and Linux would be :<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Image name : image.ext<o:p></o:p></span></p><p class=MsoPlainText><span lang=EN-US>Scaled image name : image.java-scale2x.<em><span style='font-family:"Calibri",sans-serif'>ext</span></em><o:p></o:p></span></p></blockquote><p class=MsoNormal style='margin-bottom:12.0pt'><span lang=EN-US style='font-size:12.0pt'> Both name conventions @2x and java-scale2x should be supported on Mac OS X.<br> The more specific one @2x should be checked in the first place and the java-scale2x in the second.<br><br> Thanks,<br> Alexandr.<i><br><em><span style='font-family:"Calibri",sans-serif'> </span></em><br><br><br></i></span><span lang=EN-US><o:p></o:p></span></p><blockquote style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Naming convention on windows :<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Image name : image.ext<o:p></o:p></span></p><p class=MsoPlainText><span lang=EN-US>Scaled image name : image.java-scale<dpi value>.<em><span style='font-family:"Calibri",sans-serif'>ext</span></em><o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Regards,<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Rajeev Chamyal<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p></blockquote><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'> </span><span lang=EN-US><o:p></o:p></span></p></blockquote><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt'> </span><span lang=EN-US><o:p></o:p></span></p></blockquote><p class=MsoNormal><span lang=EN-US style='font-size:12.0pt;font-family:"Times New Roman",serif'><o:p> </o:p></span></p></div></body></html>