<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma",sans-serif;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0in;
margin-right:0in;
margin-bottom:0in;
margin-left:.5in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma",sans-serif;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle21
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:621493784;
mso-list-type:hybrid;
mso-list-template-ids:1369336056 67698703 67698713 67698715 67698703 67698713 67698715 67698703 67698713 67698715;}
@list l0:level1
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level2
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level3
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level4
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level5
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level6
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
@list l0:level7
{mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level8
{mso-level-number-format:alpha-lower;
mso-level-tab-stop:none;
mso-level-number-position:left;
text-indent:-.25in;}
@list l0:level9
{mso-level-number-format:roman-lower;
mso-level-tab-stop:none;
mso-level-number-position:right;
text-indent:-9.0pt;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Hi All,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>This is a Gentle reminder for review.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Best Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ramesh BG<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> Ramesh Gangadhar <br><b>Sent:</b> Thursday, April 28, 2016 12:21<br><b>To:</b> awt-dev@openjdk.java.net<br><b>Cc:</b> Ambarish Rapte<br><b>Subject:</b> RE: <AWT Dev> Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hi All,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Gentle remainder for review.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Here is the updated webrev location:<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><a href="http://cr.openjdk.java.net/~arapte/ramesh/8129569/webrev.03/">http://cr.openjdk.java.net/~arapte/ramesh/8129569/webrev.03/</a><o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>@Ambarish:<o:p></o:p></span></p><p class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo2'><![if !supportLists]><span style='color:#1F497D'><span style='mso-list:Ignore'>1.<span style='font:7.0pt "Times New Roman"'> </span></span></span><![endif]><span style='color:#1F497D'>removed all System.out.println() calls.<o:p></o:p></span></p><p class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo2'><![if !supportLists]><span style='color:#1F497D'><span style='mso-list:Ignore'>2.<span style='font:7.0pt "Times New Roman"'> </span></span></span><![endif]><span style='color:#1F497D'>Aligned all lines to 80 chars.<o:p></o:p></span></p><p class=MsoListParagraph style='text-indent:-.25in;mso-list:l0 level1 lfo2'><![if !supportLists]><span style='color:#1F497D'><span style='mso-list:Ignore'>3.<span style='font:7.0pt "Times New Roman"'> </span></span></span><![endif]><span style='color:#1F497D'>By removing robot.delay() I can see like testcase is failing some of machines, so I have included robot.delay(500) to pass this testcase.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Best Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ramesh BG<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> Ambarish Rapte <br><b>Sent:</b> Thursday, April 21, 2016 06:31<br><b>To:</b> Ramesh Gangadhar; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> RE: <AWT Dev> Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hi Ramesh<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> The fix looks good.<o:p></o:p></span></p><p class=MsoNormal style='text-indent:.5in'><span style='color:#1F497D'>However, could you please check if the test can be run without the 6000 delay.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> Please arrange the lines to 80 char length.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> Please remove the System.out.println() calls.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ambarish<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'> Ramesh Gangadhar <br><b>Sent:</b> Tuesday, April 19, 2016 11:09 AM<br><b>To:</b> </span><a href="mailto:awt-dev@openjdk.java.net"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>awt-dev@openjdk.java.net</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'><br><b>Subject:</b> Re: <AWT Dev> Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hello All,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>This is a gentle remainder for review.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Best Regards,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ramesh BG<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> Ramesh Gangadhar <br><b>Sent:</b> Tuesday, April 12, 2016 14:41<br><b>To:</b> <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> Re: <AWT Dev> Review Request for 8027154: Test java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java fails<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Hello,<o:p></o:p></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal>Please review bug fix for 8027154<br><br>bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8027154">https://bugs.openjdk.java.net/browse/JDK-8027154</a><o:p></o:p></p><p class=MsoNormal>Webrev: <a href="http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/">http://cr.openjdk.java.net/~ralexander/8027154/webrev.02/</a><o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><b>Issue:<o:p></o:p></b></p><p class=MsoNormal>mouseMoved(MouseEvent) recieves sometimes position as [29,29] and sometimes as [30,30] from AWT native code<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><b>What modifications Done? <o:p></o:p></b></p><p class=MsoNormal>Since this testcase is mainly focused on checking mouse position instead of two Robot.mouseMove(149,149) and Robot.mouseMove(150,150) method calls it is reduced to only one call of Robot.mouseMove(150,150) and also removed creation of OuterFrame when mouseMoved on InnerFrame.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><b>Verification:<o:p></o:p></b></p><p class=MsoNormal>Code Tested on Windows and oracle linux for verification.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Best Regards,<o:p></o:p></p><p class=MsoNormal>Ramesh BG<span style='color:#1F497D'><o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b>From:</b> Ambarish Rapte <br><b>Sent:</b> Monday, April 04, 2016 4:56 PM<br><b>To:</b> Ramesh Gangadhar; <a href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br><b>Subject:</b> RE: <AWT Dev> Review Request for bug JDK-8027154<o:p></o:p></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><span style='color:#1F497D'>Hi Ramesh,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> Below are few comments,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'> General comments :<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in;text-indent:-.25in'><span style='color:#1F497D'>1.</span><span style='font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D'> </span><span style='color:#1F497D'>Please provide description about bug cause & how this change fixes the bug, with the review email.<br>Also update the bug on JBS with similar analysis.<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in;text-indent:-.25in'><span style='color:#1F497D'>2.</span><span style='font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D'> </span><span style='color:#1F497D'>Subject line for review email should in format, “Review Request For BUG_ID : BUG summary line”<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in;text-indent:-.25in'><span style='color:#1F497D'>3.</span><span style='font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D'> </span><span style='color:#1F497D'>Remove wild card import statements, @author tag & System.out.println lines.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal style='margin-left:.5in'><span style='color:#1F497D'>Comments Specific to the test:<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in;text-indent:-.25in'><span style='color:#1F497D'>4.</span><span style='font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D'> </span><span style='color:#1F497D'>Passing null to Util.waitForIdle() creates a new robot object at each call, instead please pass the created robot object.<o:p></o:p></span></p><p class=MsoListParagraph style='margin-left:1.0in;text-indent:-.25in'><span style='color:#1F497D'>5.</span><span style='font-size:7.0pt;font-family:"Times New Roman",serif;color:#1F497D'> </span><span style='color:#1F497D'>The delay on line number 86 can be removed, Util.WaitForIdle() should be sufficient for synchronization.<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'>Ambarish<o:p></o:p></span></p><p class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'> Ramesh Gangadhar <br><b>Sent:</b> Friday, April 01, 2016 12:28 PM<br><b>To:</b> </span><a href="mailto:awt-dev@openjdk.java.net"><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'>awt-dev@openjdk.java.net</span></a><span style='font-size:10.0pt;font-family:"Tahoma",sans-serif'><br><b>Subject:</b> <AWT Dev> Review Request for bug JDK-8027154<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Hello, <br><br>Please review fix for Bug 8027154<br><br>bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8027154">https://bugs.openjdk.java.net/browse/JDK-8027154</a><o:p></o:p></p><p class=MsoNormal>webrev: <a href="http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/">http://cr.openjdk.java.net/~ralexander/8027154/webrev.01/</a><span style='color:#1F497D'><o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Best Regards,<o:p></o:p></p><p class=MsoNormal>Ramesh BG<o:p></o:p></p></div></body></html>