<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Ambarish,<br>
<br>
Should we put the doc change at the top or at TextField constructor
where you actually made the change for 8055197? My take it should be
done in the latter.<br>
<div class="moz-cite-prefix">Also, I think you need a ccc for this.<br>
<br>
Regards<br>
Prasanta<br>
On 5/12/2016 12:33 PM, Ambarish Rapte wrote:<br>
</div>
<blockquote cite="mid:a3c50e71-2e70-40c9-a235-b50129f472a6@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">Please review this
documentation change for awt.TextField,<o:p></o:p></p>
<p class="MsoNormal"> Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8145284"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8145284">https://bugs.openjdk.java.net/browse/JDK-8145284</a></a><o:p></o:p></p>
<p class="MsoNormal"> Webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8145284/webrev.00/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8145284/webrev.00/">http://cr.openjdk.java.net/~arapte/8145284/webrev.00/</a></a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">What is the change:<o:p></o:p></p>
<p class="MsoNormal"> After fix of 8055197,
TextField replaces all new line characters from input string
with space characters.<o:p></o:p></p>
<p class="MsoNormal"> This behavior is not
documented, hence this change to document the behavior.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Platform Behavior:<o:p></o:p></p>
<p class="MsoNormal"> Mac:<o:p></o:p></p>
<p class="MsoNormal"> AWT does not use the native
NSTextField, but instead delegates to JPasswordField, which
replaces new line character with space character.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> On native Mac platform,
NSTextField, is not a one line text component.<o:p></o:p></p>
<p class="MsoNormal"> If input string contains
new line character then NSTextField displays multiline text.<o:p></o:p></p>
<p class="MsoNormal"> Hence we cannot consider /
replicate native platform behavior here.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> Linux:<o:p></o:p></p>
<p class="MsoNormal"> AWT delegates to peer side
JPasswordField, which replaces new line character with space
character.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> Windows:<o:p></o:p></p>
<p class="MsoNormal"> The TextField terminates
string after the new line character and was reported as
8055197.<o:p></o:p></p>
<p class="MsoNormal"> Considering the above
behavior of Linux and mac, 8055197 was fixed on windows by
replicating the same behavior of mac and linux.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">After the fix of 8055197, All the platforms
uniformly replace new line character with space character.<o:p></o:p></p>
<p class="MsoNormal">Hence the behavior should be documented.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Ambarish<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>