<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Ok. looks good to go then.<br>
<br>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 5/16/2016 7:38 PM, Ambarish Rapte
wrote:<br>
</div>
<blockquote cite="mid:580e2531-4333-4816-be94-7c61e0ac7bfe@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \, serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Prasanta,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
Thanks for the review.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
Regarding the other two constructors, These 2 constructors
do not take any direct argument as text to be set on
TextField.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
Internally these APIs call the </span>public
TextField(String text, int columns) <span
style="color:#17365D"> </span><span style="color:#1F497D">constructor,
but with empty string as argument.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">
The comment added is API argument based, Hence these 2
constructors are skipped to add comment.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Ambarish<span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
prasanta sadhukhan <br>
<b>Sent:</b> Monday, May 16, 2016 8:41 AM<br>
<b>To:</b> Ambarish Rapte; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Cc:</b> Sergey Bylokhov; Semyon Sadetsky<br>
<b>Subject:</b> Re: Review request for 8145284:
[Documentation] [TextField] Missing new line character
handling<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Ambarish,<br>
<br>
Looks good. I guess there is no harm in putting the comments
in other 2 TextField constructor too as those 2 also calls <o:p></o:p></p>
<pre>public TextField(String text, int columns)<o:p></o:p></pre>
<p class="MsoNormal">. Also, do not forget to add "noreg-doc" in
bug label as there is no testcase.<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<p class="MsoNormal">On 5/13/2016 9:20 PM, Ambarish Rapte
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi Prasanta,<o:p></o:p></p>
<p class="MsoNormal"> Please review the updated
the webrev, made changes by adding a comment to 2 Text Field
constructors & setText API.<o:p></o:p></p>
<p class="MsoNormal"> Webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8145284/webrev.01/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8145284/webrev.01/">http://cr.openjdk.java.net/~arapte/8145284/webrev.01/</a></a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> I shall raise CCC after
technical review.<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Ambarish</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
prasanta sadhukhan <br>
<b>Sent:</b> Thursday, May 12, 2016 12:44 PM<br>
<b>To:</b> Ambarish Rapte; Sergey Bylokhov; Semyon
Sadetsky; <a moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: Review request for 8145284:
[Documentation] [TextField] Missing new line character
handling</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Hi Ambarish,<br>
<br>
Should we put the doc change at the top or at TextField
constructor where you actually made the change for 8055197?
My take it should be done in the latter.<o:p></o:p></p>
<div>
<p class="MsoNormal">Also, I think you need a ccc for this.<br>
<br>
Regards<br>
Prasanta<br>
On 5/12/2016 12:33 PM, Ambarish Rapte wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal" style="text-indent:.5in">Please review
this documentation change for awt.TextField,<o:p></o:p></p>
<p class="MsoNormal"> Bug: <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8145284"><a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8145284">https://bugs.openjdk.java.net/browse/JDK-8145284</a></a><o:p></o:p></p>
<p class="MsoNormal"> Webrev: <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Earapte/8145284/webrev.00/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~arapte/8145284/webrev.00/">http://cr.openjdk.java.net/~arapte/8145284/webrev.00/</a></a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">What is the change:<o:p></o:p></p>
<p class="MsoNormal"> After fix of 8055197,
TextField replaces all new line characters from input
string with space characters.<o:p></o:p></p>
<p class="MsoNormal"> This behavior is not
documented, hence this change to document the behavior.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Platform Behavior:<o:p></o:p></p>
<p class="MsoNormal"> Mac:<o:p></o:p></p>
<p class="MsoNormal"> AWT does not use the
native NSTextField, but instead delegates to
JPasswordField, which replaces new line character with
space character.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> On native Mac platform,
NSTextField, is not a one line text component.<o:p></o:p></p>
<p class="MsoNormal"> If input string
contains new line character then NSTextField displays
multiline text.<o:p></o:p></p>
<p class="MsoNormal"> Hence we cannot
consider / replicate native platform behavior here.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> Linux:<o:p></o:p></p>
<p class="MsoNormal"> AWT delegates to peer
side JPasswordField, which replaces new line character
with space character.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> Windows:<o:p></o:p></p>
<p class="MsoNormal"> The TextField
terminates string after the new line character and was
reported as 8055197.<o:p></o:p></p>
<p class="MsoNormal"> Considering the above
behavior of Linux and mac, 8055197 was fixed on windows by
replicating the same behavior of mac and linux.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">After the fix of 8055197, All the
platforms uniformly replace new line character with space
character.<o:p></o:p></p>
<p class="MsoNormal">Hence the behavior should be
documented.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Ambarish<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New Roman
, serif","serif""> </span><o:p></o:p></p>
</blockquote>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>