<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>+1.<br>
</p>
Regards<br>
Prasanta<br>
<div class="moz-cite-prefix">On 5/24/2016 4:20 PM, Muneer Kolarkunnu
wrote:<br>
</div>
<blockquote cite="mid:a15ab099-f828-4f5a-86d2-43954ca5c124@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">New
webrev link : <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejcm/8153184/webrev.01/">http://cr.openjdk.java.net/~jcm/8153184/webrev.01/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Muneer<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Muneer Kolarkunnu <br>
<b>Sent:</b> Tuesday, May 24, 2016 4:12 PM<br>
<b>To:</b> Prasanta Sadhukhan; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: <AWT Dev> Review request for
8153184: BorderLayout javadoc says current version of
JDK is 1.2<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Hi Prasanta,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I raised ccc and it got approved:<span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
</span><a moz-do-not-send="true"
href="http://ccc.us.oracle.com/8153184">http://ccc.us.oracle.com/8153184</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Added the label "noreg-doc" to bug report
and removed the test case[It got added by mistake].<span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Muneer<o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
prasanta sadhukhan <br>
<b>Sent:</b> Tuesday, May 17, 2016 12:24 PM<br>
<b>To:</b> Muneer Kolarkunnu; <a moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: <AWT Dev> Review request for
8153184: BorderLayout javadoc says current version of
JDK is 1.2<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Looks good to
me. But the testcase has no bearing to this bug and should be
removed and "noreg-doc" label needs to be added to bugreport.<br>
Also, a ccc needs to be raised for this.<br>
<br>
Regards<br>
Prasanta<o:p></o:p></p>
<div>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
Muneer Kolarkunnu <br>
<b>Sent:</b> Thursday, May 12, 2016 5:19 PM<br>
<b>To:</b> <a moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> <AWT Dev> Review request for
8153184: BorderLayout javadoc says current version of
JDK is 1.2</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi
All,<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">
Please review the fix for bug 8153184,<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">
Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ejcm/8153184/webrev.00/">http://cr.openjdk.java.net/~jcm/8153184/webrev.00/</a><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">
Bug: <span style="color:#1F497D"><a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8153184">https://bugs.openjdk.java.net/browse/JDK-8153184</a></span><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Issue:<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:33.75pt">It
is a documentation bug, it is mentioning version information
in the javadoc, ie;”[Currently (in the Java 2 platform
v1.2)]” . So it is difficult to maintain this kind of
version information in the javadoc, just removing that
version information.<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;text-indent:33.75pt">Links
to faulty javadoc:<span style="color:#1F497D"> <a
moz-do-not-send="true"
href="http://download.java.net/java/jdk9/docs/api/java/awt/BorderLayout.html"><a class="moz-txt-link-freetext" href="http://download.java.net/java/jdk9/docs/api/java/awt/BorderLayout.html">http://download.java.net/java/jdk9/docs/api/java/awt/BorderLayout.html</a></a></span><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto;margin-left:1.5in"><span
style="color:#1F497D"> <a
moz-do-not-send="true"
href="https://docs.oracle.com/javase/8/docs/api/java/awt/BorderLayout.html"><a class="moz-txt-link-freetext" href="https://docs.oracle.com/javase/8/docs/api/java/awt/BorderLayout.html">https://docs.oracle.com/javase/8/docs/api/java/awt/BorderLayout.html</a></a></span><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span
style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Fix:<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> Removed
the version information from javadoc as it is difficult to
maintain in different versions<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Regards,<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Muneer<o:p></o:p></p>
<p class="MsoNormal"
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>