<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">The fix looks good to me.<div class=""><br class=""></div><div class="">With Regards,</div><div class="">Avik Niyogi<br class=""><div><blockquote type="cite" class=""><div class="">On 04-Jul-2016, at 2:46 pm, Alexandr Scherbatiy <<a href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class="">
  
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
  
  <div bgcolor="#FFFFFF" text="#000000" class="">
    <br class="">
    The fix looks good to me.<br class="">
    <br class="">
    Thanks,<br class="">
    Alexandr.<br class="">
    <br class="">
    <div class="moz-cite-prefix">On 7/3/2016 10:08 PM, Manajit Halder
      wrote:<br class="">
    </div>
    <blockquote cite="mid:972A7736-B50B-4E28-ACE1-F2A5D5CDC141@oracle.com" type="cite" class="">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8" class="">
      Hi Alexandr,
      <div class=""><br class="">
      </div>
      <div class="">Thank you for your review comment. I have changed
        the if condition to <span style="font-family: Menlo; color:
          rgb(0, 30, 87);" class="">chars.trim().isEmpty().</span></div>
      <div class="">Please review the modified code:</div>
      <div class=""><br class="">
      </div>
      <div class=""><a moz-do-not-send="true" href="http://cr.openjdk.java.net/%7Emhalder/7156316/webrev.01/" class="">http://cr.openjdk.java.net/~mhalder/7156316/webrev.01/</a></div>
      <div class=""><br class="">
      </div>
      <div class="">Thanks,</div>
      <div class="">Manajit</div>
      <div class=""><br class="">
        <div class="">
          <blockquote type="cite" class="">
            <div class="">On 30-Jun-2016, at 10:33 pm, Alexander
              Scherbatiy <<a moz-do-not-send="true" href="mailto:alexandr.scherbatiy@oracle.com" class="">alexandr.scherbatiy@oracle.com</a>>
              wrote:</div>
            <br class="Apple-interchange-newline">
            <div class="">
              <meta content="text/html; charset=utf-8" http-equiv="Content-Type" class="">
              <div bgcolor="#FFFFFF" text="#000000" class=""> On
                27/06/16 21:57, Manajit Halder wrote:<br class="">
                <blockquote cite="mid:78D4DBD1-9A17-4A95-A148-3DD0D1E4EC88@oracle.com" type="cite" class="">
                  <meta http-equiv="Content-Type" content="text/html;
                    charset=utf-8" class="">
                  <div class=""><span style="color: rgb(0, 30, 87);
                      line-height: 16px;" class=""><font class="" face="Menlo">Hi All,</font></span></div>
                  <div class="">
                    <div class="">
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                        </font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57">Kindly
                          review the fix for JDK9.</font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                        </font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Bug</b>: </font></div>
                      <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height:
                            16px;" class=""><a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-7156316">https://bugs.openjdk.java.net/browse/JDK-7156316</a></span></font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><u class=""><br class="">
                          </u></font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Webrev</b>: </font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo"><a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Emhalder/7156316/webrev.00/"></a><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/">http://cr.openjdk.java.net/~mhalder/7156316/webrev.00/</a></font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                        </font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Issue: </b></font></div>
                      <div class="">
                        <div class=""><span style="line-height: 16px;" class=""><font class="" face="Menlo">[macosx]
                              Ctrl+Space does generate Unknown keychar</font></span></div>
                      </div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><br class="">
                        </font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Cause: </b></font></div>
                      <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height:
                            16px;" class="">SPACK key value was received
                            as “ “ in function handleKeyEvent and that
                            was correct value, but while sending the
                            value as a character
                            to function nsToJavaChar it was getting
                            passed as 0. The function nsToJavaChar was
                            returning 0 as unichar character for SPACE
                            key as there was no code to handle the
                            situation.</span></font></div>
                      <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height:
                            16px;" class=""> </span></font></div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57"><b class="">Fix: </b></font></div>
                      <div class=""><font class="" face="Menlo" color="#001e57"><span style="line-height:
                            16px;" class="">An extra parameter was added
                            in handleKeyEvent function indicating SPACE
                            key and was passed to nsToJavaChar method to
                            handle it.</span></font></div>
                    </div>
                  </div>
                </blockquote>
                <font class="" color="#001e57"><font class="" face="Menlo">156                 if
                    ("".equals(chars.trim())) {<br class="">
                      It is better to use: chars.trim().isEmpty() or may
                    be spaceKeyTyped = </font></font><br class="">
                <font class="" color="#001e57"><font class="" face="Menlo">chars.trim().isEmpty().<br class="">
                    <br class="">
                      Thanks,<br class="">
                      Alexandr.<br class="">
                    <br class="">
                  </font></font>
                <blockquote cite="mid:78D4DBD1-9A17-4A95-A148-3DD0D1E4EC88@oracle.com" type="cite" class="">
                  <div class="">
                    <div class="">
                      <div style="line-height: 16px;" class="">
                        <div class=""><font class="" face="Menlo" color="#001e57"><br class="">
                          </font></div>
                      </div>
                      <div style="line-height: 16px;" class=""><font class="" face="Menlo" color="#001e57">Regards,<br class="">
                          Manajit</font></div>
                    </div>
                  </div>
                </blockquote>
                <br class="">
              </div>
            </div>
          </blockquote>
        </div>
        <br class="">
      </div>
    </blockquote>
    <br class="">
  </div>

</div></blockquote></div><br class=""></div></body></html>