<div dir="ltr"><div><div><div><div><div>Hello Mikhail,<br><br></div>thanks for the review.<br></div>Would you mind performing the actual commit once it is approved (I assume I need a review from a second person) ?<br></div>I have no commit rights, so I cannot do it myself.<br><br></div>Thanks<br><br></div>Robin<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 12, 2016 at 2:04 PM, Mikhail Cherkasov <span dir="ltr"><<a href="mailto:mikhail.cherkasov@oracle.com" target="_blank">mikhail.cherkasov@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
Looks good.<div><div class="h5"><br>
<br>
<div>On 12.07.2016 0:15, Robin Stevens
wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hello Mikhail,
<div><br>
</div>
<div>good catch. I adjusted the code.</div>
<div><br>
</div>
<div>Webrev: <a href="http://cr.openjdk.java.net/%7Erstevens/8160941/webrev.01" target="_blank">http://cr.openjdk.java.net/~rstevens/8160941/webrev.01</a></div>
<div><br>
</div>
<div><br>
</div>
<div>Robin</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Jul 11, 2016 at 6:08 PM,
Mikhail Cherkasov <span dir="ltr"><<a href="mailto:mikhail.cherkasov@oracle.com" target="_blank"></a><a href="mailto:mikhail.cherkasov@oracle.com" target="_blank">mikhail.cherkasov@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 11.07.2016 18:55, Robin Stevens wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
However, that would cause an inconsistency with other
operating systems.<br>
</blockquote>
</span>
ok, but then let's simplify it:<br>
<br>
remove this line:<br>
sb.append(strings[0]);<br>
<br>
and start cycle from 0:<br>
for(int i = 0; i < strings.length; i++) {<br>
sb.append(strings[i]);<br>
sb.append(separator);<br>
}<br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</div></div></div>
</blockquote></div><br></div>