<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Looks good to me.<br>
<br>
--Semyon<br>
<br>
<div class="moz-cite-prefix">On 14.07.2016 09:52, Ajit Ghaisas
wrote:<br>
</div>
<blockquote cite="mid:fb24d5a1-16c8-4fea-911f-b5d197d01eac@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Thanks Phil. <o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">I have updated
the test as discussed. Here is the updated webrev.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eaghaisas/8159956/webrev.01/"><a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~aghaisas/8159956/webrev.01/">http://cr.openjdk.java.net/~aghaisas/8159956/webrev.01/</a></a><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D">Ajit<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="color:windowtext">From:</span></b><span
style="color:windowtext"> Philip Race <br>
<b>Sent:</b> Wednesday, July 13, 2016 10:11 PM<br>
<b>To:</b> Ajit Ghaisas<br>
<b>Cc:</b> Semyon Sadetsky; <a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: [9] Fix for JDK-8159956 :
EXCEPTION_ACCESS_VIOLATION in
sun.awt.windows.ThemeReader.getThemeMargins<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">This seems fine to me although as mentioned
off-line<br>
I think the test could be made to run on all platforms.<br>
<br>
-phil.<br>
<br>
<br>
On 7/11/16, 3:04 AM, Ajit Ghaisas wrote: <span
style="font-size:12.0pt"><o:p></o:p></span></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> This is the fix for JVM crash bug.<o:p></o:p></p>
<p class="MsoNormal"> <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8159956">https://bugs.openjdk.java.net/browse/JDK-8159956</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Root Cause :<o:p></o:p></p>
<p class="MsoNormal"> newInsets() method in
java.desktop/windows/native/libawt/windows/ThemeReader.cpp
file tries to access AwtToolkit::insetsMID method id. <o:p></o:p></p>
<p class="MsoNormal"> In awt headless mode, this method id
is not initialized. Trying to access it results in JVM
crash.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Fix :<o:p></o:p></p>
<p class="MsoNormal"> Creating an object of ‘Insets’ class
is allowed in awt headless mode. (Refer to existing test -
test/java/awt/Insets/HeadlessInsets.java)<o:p></o:p></p>
<p class="MsoNormal"> AwtToolkit::insetsMID method is a
handle to the constructor of Insets class.<o:p></o:p></p>
<p class="MsoNormal"> The fix for this bug is to Initialize
the AwtToolkit::insetsMID even in awt headless mode.<o:p></o:p></p>
<p class="MsoNormal"> This is achieved by invoking native
method initIDs() from Toolkit.java static initializer block
– this was avoided in headless mode using a check. I have
removed this check.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Webrev :<o:p></o:p></p>
<p class="MsoNormal"> <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Eaghaisas/8159956/webrev.00">http://cr.openjdk.java.net/~aghaisas/8159956/webrev.00</a><o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> Request you to review.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Ajit<o:p></o:p></p>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>