<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre><span class="new">Hi,
Are you sure this is all the files ? Seems like I should be seeing
some implementation of this on the Java side.
General question: What is the coordinate system for x/y/w/h on a 'hi-dpi'
configuration ? Can we add a note somewhere about this.
</span><span class="new">The alignment looks off in mapfile-mawt-vers and mapfile-vers-linux</span>
<span class="new">
290 * creates with matching platform information.</span></pre>
creates -> created<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre><span class="new">296 * Moves and resize the embedded frame.</span></pre>
Either<br>
moves -> move<br>
or<br>
resize -> resizes<br>
<br>
ie it should be either "move and resize", or "moves and resizes"<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre><span class="new">* setLocation() and setBounds() for EmbeddedFrame really don't move it</span>
could we spell out java.awt.Component.setLocation() and java.awt.Component.setBounds()
so it is clear what methods are meant.
<span class="new">304 * within the native parent. These methods always put embedded frame to</span>
put embedded frame to -> locate the embedded frame at
<span class="new">305 * (0, 0) for backward compatibility. To allow moving embedded frames</span>
<span class="new"> 306 * this method was introduced, and it work just the same way as</span>
work -> works
<span class="new">307 * setLocation() and setBounds() for usual, non-embedded components.</span></pre>
<br>
I presume a typical usage of this method will be to resize the
embedded frame<br>
if the native container is re-sized ?<br>
<br>
Should there be an additional note here about who's responsibility
it is<br>
to track resize on the native container and then call this method ?<br>
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<pre><span class="new">Synthesize native message</span><meta http-equiv="content-type" content="text/html; charset=UTF-8"><span class="new"> to activate or deactivate EmbeddedFrame </span>
<span class="new"> ^ ^
a an
</span></pre>
-phil.<br>
<br>
On 8/1/16, 5:39 AM, Sergey Bylokhov wrote:
<blockquote
cite="mid:91e0a1a6-6f87-bcc3-8f06-2d2be330885a@oracle.com"
type="cite">Hello.
<br>
Please review the fix for jdk9.
<br>
<br>
In the fix the part of our internal api is opened via jawt library
which is a jdk api, so the important part of the fix is in the
jawt.h file. This api can be used by other toolkits to implement
embedding of awt/swing components into some other native windows.
<br>
<br>
There are no tests in the fix since I plan to implement a number
of tests via separate CR.(but I am not sure what is the best way
to create a native dll, which will reuse jawt api ->
manual/precompiled dll/ compilation on the fly?).
<br>
<br>
jprt job is passed, the ccc will be filed after the technical
review.
<br>
<br>
- JAWT_VERSION_9 is used intentionally instead of
JAWT_VERSION_1_9.
<br>
- On OSX validateWithBounds() intentionally was changed to
setBoundsPrivate() as on other platforms.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8148109">https://bugs.openjdk.java.net/browse/JDK-8148109</a>
<br>
Webrev can be found at:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~serb/8148109/webrev.00">http://cr.openjdk.java.net/~serb/8148109/webrev.00</a>
<br>
<br>
</blockquote>
</body>
</html>