<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Could you also send the review to the 2d-dev alias?<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<div class="moz-cite-prefix">On 8/18/2016 9:59 AM, Prem Balakrishnan
wrote:<br>
</div>
<blockquote cite="mid:ba185e2c-93cb-438c-8871-ef0883a0542e@default"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \, serif";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle24
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle25
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle26
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle27
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span style="color:#1F497D">Hi Alexandr,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal">AccelSurface is implemented by *ONLY*
D3DSurfaceData and OGLSurfaceData classes,<o:p></o:p></p>
<p class="MsoNormal">Both of these classes extend SurfaceData as
well.<o:p></o:p></p>
<p class="MsoNormal">Hence, casting of 'as' variable which is of
type AccelSurface object to SurfaceData is always VALID.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<br>
Prem<span style="color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Alexandr Scherbatiy <br>
<b>Sent:</b> Wednesday, August 17, 2016 4:42 PM<br>
<b>To:</b> Prem Balakrishnan; Rajeev Chamyal;
<a class="moz-txt-link-abbreviated" href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>; Sergey Bylokhov<br>
<b>Subject:</b> Re: Review Request: JDK-8144735 [hidpi]
javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java
fails<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">On 8/17/2016 11:30 AM, Prem Balakrishnan
wrote:<br>
<br>
<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Alexandr,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Thankyou for
the review.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">YES scaled
SurfaceData returns proper scale values from
getDefaultScaleX()/getDefaultScaleY(), which I have used in
the current patch.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
the updated patch</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span
lang="EN-IN"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.02/">http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.02/</a></span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""> Is it always true that the
'as' variable which has type AccelSurface in the fix is
always instance of SurfaceData?<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span
style="color:#1F497D" lang="EN-IN">Regards,<br>
Prem</span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Alexandr Scherbatiy <br>
<b>Sent:</b> Tuesday, August 16, 2016 10:06 PM<br>
<b>To:</b> Prem Balakrishnan; Rajeev Chamyal; <a
moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
Sergey Bylokhov<br>
<b>Subject:</b> Re: Review Request: JDK-8144735 [hidpi]
javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java
fails</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal">On 8/16/2016 7:35 AM, Prem Balakrishnan
wrote:<br>
<br>
<br>
<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Reminder</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Prem Balakrishnan <br>
<b>Sent:</b> Friday, August 12, 2016 6:36 PM<br>
<b>To:</b> Alexander Scherbatiy; Rajeev Chamyal; <a
moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
Sergey Bylokhov<br>
<b>Subject:</b> RE: Review Request: JDK-8144735 [hidpi]
javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java
fails</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Hi Alexandr and
Sergey,</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Please review
the updated patch.</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span
lang="EN-IN"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.01/">http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.01/</a></span><o:p></o:p></p>
<p class="MsoPlainText">>>“It is a little bit strange bug,
because VolatileImage should handle this scale internally, and
create double sized surface when necessary”.-Sergey<o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D">Yes as you
mentioned Volatile Image is getting scaled internally.
Thanks for the feedback.</span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<pre><b><span style="font-family:"Calibri","sans-serif"">Cause:</span></b><span style="font-family:"Calibri","sans-serif";color:#1F497D"> In </span><span style="color:#1F497D">VIOptWindowPainter::updateWindowAccel(psdops, w, h) call, width and height were passed without scaling,</span><o:p></o:p></pre>
<pre><span style="color:#1F497D">which was creating a bitmap of specified width and height, hence the output was clipped.</span><o:p></o:p></pre>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New Roman ,
serif","serif""><br>
I just have two general questions.<br>
- The scaled SurfaceData should return proper scales from
getDefaultScaleX()/getDefaultScaleY() methods. Do these
methods return right values after setting the scaled image
sizes in the fix?<br>
- Region.clipScale() which is used in many places rounds
values. The usual rule is to use Math.floor() for image
coordinates rounding and Math.ceil() for sizes.<br>
Should the same rule be applicable here?<br>
<br>
Thanks,<br>
Alexandr.<br>
<br>
<br>
<br>
<br>
</span><o:p></o:p></p>
<pre><span style="font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></pre>
<pre><span style="font-family:"Calibri","sans-serif";color:#1F497D"> </span><o:p></o:p></pre>
<pre><span style="font-family:"Calibri","sans-serif";color:#1F497D">Regards,</span><o:p></o:p></pre>
<pre><span style="font-family:"Calibri","sans-serif";color:#1F497D">Prem</span><o:p></o:p></pre>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:#1F497D"> </span><o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext">
Alexandr Scherbatiy <br>
<b>Sent:</b> Thursday, August 04, 2016 6:23 PM<br>
<b>To:</b> Prem Balakrishnan; Rajeev Chamyal; <a
moz-do-not-send="true"
href="mailto:awt-dev@openjdk.java.net">awt-dev@openjdk.java.net</a>;
Sergey Bylokhov<br>
<b>Subject:</b> Re: Review Request: JDK-8144735 [hidpi]
javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java
fails</span><o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">On 8/3/2016
10:04 AM, Prem Balakrishnan wrote:<o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify"><span
lang="EN-IN">Hi,</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN">Please review fix for JDK9,</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify"><span
style="color:#1F497D" lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><b><span
lang="EN-IN">Bug:</span></b><span lang="EN-IN"> <a
moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8144735">https://bugs.openjdk.java.net/browse/JDK-8144735</a>
</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
style="color:#1F497D" lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><b><span
lang="EN-IN">Webrev:</span></b><span lang="EN-IN"> <a
moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Epkbalakr/8144735/webrev.00/">http://cr.openjdk.java.net/~pkbalakr/8144735/webrev.00/</a>
</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><b><span
lang="EN-IN">Issue:</span></b><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN">javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java
fails </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><b><span
lang="EN-IN">Cause:</span></b><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN">While creating Transparent VolatileImage, width
and height was NOT hidpi scaled.</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><b><span
lang="EN-IN">Fix: </span></b><span lang="EN-IN">VolatileImage
width and height are scaled.</span><o:p></o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span
style="font-size:12.0pt"><br>
I believe this is an issue in AWT and needs to be
discussed on awt-dev alias.<br>
<br>
Should the backbuffer width and height be also scaled for
the BIWindowPainter?<br>
<br>
Thanks,<br>
Alexandr.<br>
</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify;text-indent:.5in"><span
lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify"><span
lang="EN-IN">Thanks,</span><o:p></o:p></p>
<p class="MsoNormal" style="text-align:justify"><span
lang="EN-IN">Prem</span><o:p></o:p></p>
<p class="MsoNormal"><span lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt" lang="EN-IN"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="color:windowtext"> </span><o:p></o:p></p>
<p class="MsoNormal"><span style="font-size:12.0pt"> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New Roman ,
serif","serif""> </span><o:p></o:p></p>
<p class="MsoNormal"><span
style="font-size:12.0pt;font-family:"Times New
Roman","serif""><o:p> </o:p></span></p>
</div>
</blockquote>
<br>
</body>
</html>