<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
I've been testing this by re-enabling deprecation so<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/02/2016 10:50 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote
cite="mid:510b4057-8e7c-0ece-5e98-c7fa2ce3d8f4@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>Do we need the suppression in JavaSoundAudioClip.java as I
could not find any mention of Applet in that class?<br>
</p>
<span class="changed">In AppletViewer.java</span> <br>
shouldn't we need to add "deprecation" to <br>
<pre><span class="changed">45 @SuppressWarnings("serial") // JDK implementation class
</span></pre>
</blockquote>
No, it is not needed there since "TextFrame" isn't using any
deprecated class.<br>
<blockquote
cite="mid:510b4057-8e7c-0ece-5e98-c7fa2ce3d8f4@oracle.com"
type="cite">
<pre><span class="changed">
</span>Do we still need this
160 @SuppressWarnings("deprecation")
since we added
<span class="changed">120 @SuppressWarnings({"serial", "deprecation"})</span></pre>
</blockquote>
<br>
I agree 160 should not be needed.<br>
<blockquote
cite="mid:510b4057-8e7c-0ece-5e98-c7fa2ce3d8f4@oracle.com"
type="cite">
<pre>
Other than that, looks good to me.</pre>
</blockquote>
<br>
OK. I'm going to push with this tweak as the deprecation warnings<br>
are starting to pile up again and I need to get at least part of it
fixed.<br>
<br>
-phil<br>
<blockquote
cite="mid:510b4057-8e7c-0ece-5e98-c7fa2ce3d8f4@oracle.com"
type="cite">
<pre>
Regards
Prasanta
</pre>
<div class="moz-cite-prefix">On 10/20/2016 1:44 AM, Philip Race
wrote:<br>
</div>
<blockquote cite="mid:5807D43A.10409@oracle.com" type="cite">Bug:
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8168316">https://bugs.openjdk.java.net/browse/JDK-8168316</a>
<br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eprr/8168316/">http://cr.openjdk.java.net/~prr/8168316/</a>
<br>
<br>
When applets were deprecated it seems that due to all deprecated
<br>
warning being suppressed in java.desktop many places that should
<br>
have been updated weren't <br>
<br>
This resolves the applet ones .. as a precursor to fixing up the
other issues <br>
that cause this global supression. <br>
<br>
-phil <br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>